Workaround Arma bug with moveInAny #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the only other active use of moveInAny is the salvage patrol boat, so nothing else needs fixing urgently. |
MeltedPixel
approved these changes
Apr 5, 2023
igorkis-scrts
pushed a commit
to igorkis-scrts/A3-Antistasi-Plus
that referenced
this pull request
Aug 8, 2023
…M-reb-trucks Workaround Arma bug with moveInAny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
spawnHCGroup used moveInAny to board every unit except the driver for rebel infantry trucks. Unfortunately this is bugged, and moveInAny somehow breaks driving AI when used to move an AI into a gunner seat, such that they'll refuse to drive anywhere, or occasionally act like they have a brick wall in front. setEffectiveCommander to the driver will allow them to drive again, but setting it back to gunner (which is default) will block them again. You can do moveInDriver + moveInGunner and it's fine, while moveInDriver + moveInAny will break. Tested with Hunter HMG, Marshall and a couple of GM armed trucks.
Currently this is only an identified problem with GM rebel trucks, so that's what I've fixed. Other usage of moveInAny should be checked, however.
Please specify which Issue this PR Resolves.
closes #2647
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
Need to check other uses of moveInAny.