Rework Petros death handling #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeltedPixel
approved these changes
Apr 11, 2023
Bob-Murphy
approved these changes
Apr 11, 2023
igorkis-scrts
pushed a commit
to igorkis-scrts/A3-Antistasi-Plus
that referenced
this pull request
Aug 8, 2023
…k-petros-death Rework Petros death handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Petros post-death placement handling wasn't reliable. If a player managed to exit the placement interface (eg. by dying or disconnecting) then no-one would have access to the placement control.
With this PR, a petros death instead triggers a monitor loop that triggers the placement UI on suitable commanders. It survives both commander deaths and disconnections, and any other map close actions.
Please specify which Issue this PR Resolves.
closes #2701
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?