Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround some bad GL configs #2727

Merged

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Apr 8, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

  • compatibleMagazines [weapon, muzzle] is case-sensitive on the muzzle. This is a bug. "UK3CB_G3KA4_GL" has bad casing on the grenade launcher muzzle. This is a bug. We have to deal with it because it's our shit that it breaks.

  • Some RHS M70 rifles have a rifle grenade muzzle which has no compatible magazines. categoryOverrides it is.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added the Bug-fix label Apr 8, 2023
@jaj22 jaj22 added this to the 3.2 milestone Apr 8, 2023
Copy link
Member

@CalebSerafin CalebSerafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Software Developers Loogs Good to Me LGTM

@CalebSerafin CalebSerafin merged commit 4adf546 into official-antistasi-community:unstable Apr 8, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label May 8, 2023
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants