Test-fix for establishing a roadblock using remote control #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k mission by remote controlling
igorkis-scrts
pushed a commit
to igorkis-scrts/A3-Antistasi-Plus
that referenced
this pull request
Aug 8, 2023
…oadblock-RC-fail Test-fix for establishing a roadblock using remote control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
There have been several cases of players breaking badly by completing a roadblock using remote control, including Arma crashes and broken player objects. Couldn't replicate, maybe because a dedicated server with significant latency is required.
The roadblock code has specific logic for this, which is bad but shouldn't cause this sort of problem. My best guess is that the problem is that the roadblock code deletes the units immediately after, and this can outpace some selectPlayer functionality. Added a short delay and removed some redundant operations that wouldn't have worked correctly anyway due to remoteExec order.
Please specify which Issue this PR Resolves.
maybe closes #1964
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
See if there are no further reports within six months or so.