Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zeus Logs #2750

Merged

Conversation

killerswin2
Copy link

@killerswin2 killerswin2 commented Apr 25, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Adds logging of what Zeus is doing. Logs Zeus activities for Admins of servers.

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

@killerswin2
Copy link
Author

17:01:50 2023-04-25 22:01:50:487 | Antistasi | Info | File: A3A_fnc_zuesLogging | Event: CuratorObjectSelectionChanged Curator: Killerswin2 Object: commanderX Object Type: I_G_Soldier_TL_F 17:01:54 2023-04-25 22:01:54:421 | Antistasi | Info | File: A3A_fnc_zuesLogging | Event: CuratorObjectSelectionChanged Curator: Killerswin2 Object: flagX Object Type: Flag_FIA_F Example

@killerswin2 killerswin2 changed the title Add Zues Logs Add Zeus Logs Apr 25, 2023
@rautamiekka
Copy link

All zues to zeus.

@CalebSerafin
Copy link
Member

Note, unless additional hooks are added, any actions done by Zeus modules spawned at runtime will be incognito.

@killerswin2
Copy link
Author

Hmm, best recommendation? Just spawn a script that counts allCurators?

@CalebSerafin
Copy link
Member

CalebSerafin commented Apr 27, 2023

You don't need to wipe the event handlers off all modules and then add them again. You can remember which modules you already added EHs to by keeping a list. Maybe see if and which event is raised when ACE or Zues enhanced creates a Curator Module.

Checking for modules or tampering done by script kiddies is certainly out of scope because at that point it's a lost cause. So don't worry too much about workarounds via the debug console.

@killerswin2
Copy link
Author

Ace and Zues don't create curator modules? I thought you wanted the dynamic detection for script kiddies?

@HakonRydland
Copy link
Collaborator

@killerswin2
Copy link
Author

killerswin2 commented Apr 27, 2023

um... you do realize that is executed on every created entity. Even butterflies and bunnies. I don't think searching for "curatorModuleF" for every created entity is smart

@CalebSerafin
Copy link
Member

ACE and Zues must create curator modules. Otherwise, people would not be able to promote others to Zeus or create for themselves. It just automates the process of using the debug console to create a module at runtime.

@CalebSerafin
Copy link
Member

But yeah, if one of those systems doesn't provide somewhere where you can hook in code, then a background server/HC side script that periodically scans for curator modules and filters the new ones would be the better solution.

@killerswin2
Copy link
Author

I found the ace and zen events

@Bob-Murphy Bob-Murphy added this to the 3.3 milestone May 6, 2023
@Bob-Murphy
Copy link

@killerswin2 is this ready to review?
If so, please add the label.

@jaj22
Copy link

jaj22 commented Jul 15, 2023

Ok, doesn't actually work on DS. The documentation is a disaster but the curator events must be added locally to the player who's in the curator AI (eg. from initClient), even though they're added to the curator object.

Move the initial zeus event call to initClient, I guess, and remoteExec it from the server events. At least you already have ServerInfo so that part is fine.

Copy link

@rautamiekka rautamiekka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if outdated reviews got included since it said I had 4 unsubmitted.

EDIT: Yeah, they did. Ah well, deleted those.

A3A/addons/core/functions/init/fn_initServer.sqf Outdated Show resolved Hide resolved
A3A/addons/core/functions/init/fn_initServer.sqf Outdated Show resolved Hide resolved
A3A/addons/core/functions/init/fn_initVarCommon.sqf Outdated Show resolved Hide resolved
killerswin2 and others added 2 commits July 16, 2023 13:14
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
killerswin2 and others added 2 commits July 16, 2023 13:15
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@killerswin2 killerswin2 requested a review from jaj22 July 16, 2023 18:17
Copy link

@jaj22 jaj22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic functionality with built-in zeus works. Haven't tested the others because they need multiple players, but it can't do anything show-stopping if it's broken.

@Bob-Murphy Bob-Murphy merged commit 86ad39b into official-antistasi-community:unstable Jul 16, 2023
killerswin2 added a commit that referenced this pull request Jul 16, 2023
* Bugfix (Duplicate rebel vehicles/unarmed AFRF tigr) #2779 #2765 (#2805)

* Fixed RHS AFRF roadblock vehicle #2765

* Fixed Duplicate rebel vehicle entries #2779

* Update Vanilla_Reb_FIA.sqf

Conditional add of civilian jeep to FIA template

* missing semi-colon ;(

* Fix some RHS flags (#2790)

* Update publishBranchToSteam.yml

* fix flags for CDF, NAPA and SAF

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>

* Add parameter to control Loot To Crate distance (#2777)

* Update publishBranchToSteam.yml

* Fix trailing comma and missing AA plane in ION Temperate

* Added LooToCreateDistance

* Fix typo.

* - Renamed LootToCrateDistance to LootToCrate Radius.
- Adjusted LootToCrateRadius values.

* Adjusted text spacing.

* Combined LootToCrateEnabled and LootToCrateRadius.

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>

* Fix mismerge of LTC radius parameter PR

* Discounted rebel 7.62 and 5.56 vics/statics

* Don't place units or statics on destroyed buildings

* Don't spam hints while setup dialog is open

* Fix undercover backpack exploit (#2817)

* Fix exploit with undercover AI and static/device backpacks

* Fix case where unit lacks a backpack

* Rudimentary Sog 1.3 Update (#2794)

* init commit

* johns changes, and more statics for pof

* move m67 to IFVs

* remove m101_02

* Add Zeus Logs (#2750)

* init

* add a check for multiple zeus modules

* add zen events and ace zeus events

* fix spelling

* update to use serverlog

* space fix

* change

* another change

* correct fix

* another changed

* Update A3A/addons/core/functions/init/fn_initServer.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* Update A3A/addons/core/functions/init/fn_initServer.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* Update A3A/addons/core/functions/init/fn_initVarCommon.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* missing semi_colon

---------

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

---------

Co-authored-by: ante185 <49555217+ante185@users.noreply.github.com>
Co-authored-by: MadBender <ryder86@gmail.com>
Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>
Co-authored-by: Joshua Engler <englerj@live.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Bob-Murphy added a commit that referenced this pull request Jul 24, 2023
* Cherno 2020 - initial commit

* outpost and radiotower update

* minor map fixes

* added control marker at NE airfield

* Update Branch for testing (#2826)

* Bugfix (Duplicate rebel vehicles/unarmed AFRF tigr) #2779 #2765 (#2805)

* Fixed RHS AFRF roadblock vehicle #2765

* Fixed Duplicate rebel vehicle entries #2779

* Update Vanilla_Reb_FIA.sqf

Conditional add of civilian jeep to FIA template

* missing semi-colon ;(

* Fix some RHS flags (#2790)

* Update publishBranchToSteam.yml

* fix flags for CDF, NAPA and SAF

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>

* Add parameter to control Loot To Crate distance (#2777)

* Update publishBranchToSteam.yml

* Fix trailing comma and missing AA plane in ION Temperate

* Added LooToCreateDistance

* Fix typo.

* - Renamed LootToCrateDistance to LootToCrate Radius.
- Adjusted LootToCrateRadius values.

* Adjusted text spacing.

* Combined LootToCrateEnabled and LootToCrateRadius.

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>

* Fix mismerge of LTC radius parameter PR

* Discounted rebel 7.62 and 5.56 vics/statics

* Don't place units or statics on destroyed buildings

* Don't spam hints while setup dialog is open

* Fix undercover backpack exploit (#2817)

* Fix exploit with undercover AI and static/device backpacks

* Fix case where unit lacks a backpack

* Rudimentary Sog 1.3 Update (#2794)

* init commit

* johns changes, and more statics for pof

* move m67 to IFVs

* remove m101_02

---------

Co-authored-by: ante185 <49555217+ante185@users.noreply.github.com>
Co-authored-by: MadBender <ryder86@gmail.com>
Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>
Co-authored-by: Joshua Engler <englerj@live.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>

* Another update for testing (#2827)

* Bugfix (Duplicate rebel vehicles/unarmed AFRF tigr) #2779 #2765 (#2805)

* Fixed RHS AFRF roadblock vehicle #2765

* Fixed Duplicate rebel vehicle entries #2779

* Update Vanilla_Reb_FIA.sqf

Conditional add of civilian jeep to FIA template

* missing semi-colon ;(

* Fix some RHS flags (#2790)

* Update publishBranchToSteam.yml

* fix flags for CDF, NAPA and SAF

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>

* Add parameter to control Loot To Crate distance (#2777)

* Update publishBranchToSteam.yml

* Fix trailing comma and missing AA plane in ION Temperate

* Added LooToCreateDistance

* Fix typo.

* - Renamed LootToCrateDistance to LootToCrate Radius.
- Adjusted LootToCrateRadius values.

* Adjusted text spacing.

* Combined LootToCrateEnabled and LootToCrateRadius.

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>

* Fix mismerge of LTC radius parameter PR

* Discounted rebel 7.62 and 5.56 vics/statics

* Don't place units or statics on destroyed buildings

* Don't spam hints while setup dialog is open

* Fix undercover backpack exploit (#2817)

* Fix exploit with undercover AI and static/device backpacks

* Fix case where unit lacks a backpack

* Rudimentary Sog 1.3 Update (#2794)

* init commit

* johns changes, and more statics for pof

* move m67 to IFVs

* remove m101_02

* Add Zeus Logs (#2750)

* init

* add a check for multiple zeus modules

* add zen events and ace zeus events

* fix spelling

* update to use serverlog

* space fix

* change

* another change

* correct fix

* another changed

* Update A3A/addons/core/functions/init/fn_initServer.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* Update A3A/addons/core/functions/init/fn_initServer.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* Update A3A/addons/core/functions/init/fn_initVarCommon.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* missing semi_colon

---------

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

---------

Co-authored-by: ante185 <49555217+ante185@users.noreply.github.com>
Co-authored-by: MadBender <ryder86@gmail.com>
Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>
Co-authored-by: Joshua Engler <englerj@live.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* double outpost fix

* Cherno 2020 - initial commit

* outpost and radiotower update

* minor map fixes

* added control marker at NE airfield

* Rebase of Chernarus2020 branch to unstable

* double outpost fix

* cover update

* pic update

---------

Co-authored-by: Bob-Murphy <Bob-Murphy@users.noreply.github.com>
Co-authored-by: Ellis Nielsen <thecakebecamethelie@yahoo.com>
Co-authored-by: ante185 <49555217+ante185@users.noreply.github.com>
Co-authored-by: MadBender <ryder86@gmail.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>
Co-authored-by: Joshua Engler <englerj@live.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Jul 25, 2023
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
* init

* add a check for multiple zeus modules

* add zen events and ace zeus events

* fix spelling

* update to use serverlog

* space fix

* change

* another change

* correct fix

* another changed

* Update A3A/addons/core/functions/init/fn_initServer.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* Update A3A/addons/core/functions/init/fn_initServer.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* Update A3A/addons/core/functions/init/fn_initVarCommon.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* missing semi_colon

---------

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
* Cherno 2020 - initial commit

* outpost and radiotower update

* minor map fixes

* added control marker at NE airfield

* Update Branch for testing (official-antistasi-community#2826)

* Bugfix (Duplicate rebel vehicles/unarmed AFRF tigr) official-antistasi-community#2779 official-antistasi-community#2765 (official-antistasi-community#2805)

* Fixed RHS AFRF roadblock vehicle official-antistasi-community#2765

* Fixed Duplicate rebel vehicle entries official-antistasi-community#2779

* Update Vanilla_Reb_FIA.sqf

Conditional add of civilian jeep to FIA template

* missing semi-colon ;(

* Fix some RHS flags (official-antistasi-community#2790)

* Update publishBranchToSteam.yml

* fix flags for CDF, NAPA and SAF

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>

* Add parameter to control Loot To Crate distance (official-antistasi-community#2777)

* Update publishBranchToSteam.yml

* Fix trailing comma and missing AA plane in ION Temperate

* Added LooToCreateDistance

* Fix typo.

* - Renamed LootToCrateDistance to LootToCrate Radius.
- Adjusted LootToCrateRadius values.

* Adjusted text spacing.

* Combined LootToCrateEnabled and LootToCrateRadius.

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>

* Fix mismerge of LTC radius parameter PR

* Discounted rebel 7.62 and 5.56 vics/statics

* Don't place units or statics on destroyed buildings

* Don't spam hints while setup dialog is open

* Fix undercover backpack exploit (official-antistasi-community#2817)

* Fix exploit with undercover AI and static/device backpacks

* Fix case where unit lacks a backpack

* Rudimentary Sog 1.3 Update (official-antistasi-community#2794)

* init commit

* johns changes, and more statics for pof

* move m67 to IFVs

* remove m101_02

---------

Co-authored-by: ante185 <49555217+ante185@users.noreply.github.com>
Co-authored-by: MadBender <ryder86@gmail.com>
Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>
Co-authored-by: Joshua Engler <englerj@live.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>

* Another update for testing (official-antistasi-community#2827)

* Bugfix (Duplicate rebel vehicles/unarmed AFRF tigr) official-antistasi-community#2779 official-antistasi-community#2765 (official-antistasi-community#2805)

* Fixed RHS AFRF roadblock vehicle official-antistasi-community#2765

* Fixed Duplicate rebel vehicle entries official-antistasi-community#2779

* Update Vanilla_Reb_FIA.sqf

Conditional add of civilian jeep to FIA template

* missing semi-colon ;(

* Fix some RHS flags (official-antistasi-community#2790)

* Update publishBranchToSteam.yml

* fix flags for CDF, NAPA and SAF

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>

* Add parameter to control Loot To Crate distance (official-antistasi-community#2777)

* Update publishBranchToSteam.yml

* Fix trailing comma and missing AA plane in ION Temperate

* Added LooToCreateDistance

* Fix typo.

* - Renamed LootToCrateDistance to LootToCrate Radius.
- Adjusted LootToCrateRadius values.

* Adjusted text spacing.

* Combined LootToCrateEnabled and LootToCrateRadius.

---------

Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>

* Fix mismerge of LTC radius parameter PR

* Discounted rebel 7.62 and 5.56 vics/statics

* Don't place units or statics on destroyed buildings

* Don't spam hints while setup dialog is open

* Fix undercover backpack exploit (official-antistasi-community#2817)

* Fix exploit with undercover AI and static/device backpacks

* Fix case where unit lacks a backpack

* Rudimentary Sog 1.3 Update (official-antistasi-community#2794)

* init commit

* johns changes, and more statics for pof

* move m67 to IFVs

* remove m101_02

* Add Zeus Logs (official-antistasi-community#2750)

* init

* add a check for multiple zeus modules

* add zen events and ace zeus events

* fix spelling

* update to use serverlog

* space fix

* change

* another change

* correct fix

* another changed

* Update A3A/addons/core/functions/init/fn_initServer.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* Update A3A/addons/core/functions/init/fn_initServer.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* Update A3A/addons/core/functions/init/fn_initVarCommon.sqf

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* missing semi_colon

---------

Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

---------

Co-authored-by: ante185 <49555217+ante185@users.noreply.github.com>
Co-authored-by: MadBender <ryder86@gmail.com>
Co-authored-by: Bob-Murphy <50651578+Bob-Murphy@users.noreply.github.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>
Co-authored-by: Joshua Engler <englerj@live.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>

* double outpost fix

* Cherno 2020 - initial commit

* outpost and radiotower update

* minor map fixes

* added control marker at NE airfield

* Rebase of Chernarus2020 branch to unstable

* double outpost fix

* cover update

* pic update

---------

Co-authored-by: Bob-Murphy <Bob-Murphy@users.noreply.github.com>
Co-authored-by: Ellis Nielsen <thecakebecamethelie@yahoo.com>
Co-authored-by: ante185 <49555217+ante185@users.noreply.github.com>
Co-authored-by: MadBender <ryder86@gmail.com>
Co-authored-by: Artyom Vasilyev <vasilyev.artem.v@gmail.com>
Co-authored-by: Joshua Engler <englerj@live.com>
Co-authored-by: John Jordan <jaj22x@gmail.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants