Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in lightAPC & IFV categorization #2833

Merged

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Jul 20, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Light APCs were missing from the vehiclesArmor list and IFVs were blocked by a rogue semicolon, with the following effects:

  • Not breachable.
  • Labelled as MRAP on map.
  • Crew bailing out inappropriately.
  • CAS not using missiles against them.

Also fixed a related typo in currently-unused vehicle selection code.

Please specify which Issue this PR Resolves.

closes #2824

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added the Bug-fix label Jul 20, 2023
@jaj22 jaj22 added this to the 3.3 milestone Jul 20, 2023
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bob-Murphy Bob-Murphy merged commit a225e46 into official-antistasi-community:unstable Jul 20, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Jul 25, 2023
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
…ehiclesArmor-list

Fix typos in lightAPC & IFV categorization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Light APCs aren't breachable
3 participants