Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying allowed build options #915

Closed
GediminasMasaitis opened this issue Apr 17, 2021 · 1 comment
Closed

Specifying allowed build options #915

GediminasMasaitis opened this issue Apr 17, 2021 · 1 comment

Comments

@GediminasMasaitis
Copy link

It would be great if you could control what build options the test is allowed to run with. There are cases where a patch only affects a specific build, take official-stockfish/Stockfish#3429 for example.

By default set the build to "unspecified" - whatever goes. Otherwise, if the worker machine doesn't support one of the required architectures it would be disqualified from running the test.

I suppose there are multiple ways of determining what build options are available:

  • Parsing the makefile
  • Including build options metadata with stockfish source, maybe a json file? Well some easy-to-parse configuration.
  • Coding the available options into fishtest (quite nasty imo)

I think a dedicated configuration file would be the best option, even though it could introduce discrepancies with the makefile. This should be controlled with Stockfish PRs though to remind people to update the fishtest configuation if they change the build parameters in the makefile.

@ppigazzini
Copy link
Collaborator

fishtest already "parse the Stockfish makefile" and "check the worker CPU architecture", see
https://github.com/glinscott/fishtest/blob/3188235f65849a2c11bcb0123bf0bd922cc2e439/worker/games.py#L257-L379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants