[BUGFIX] Debounce context not properly set #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@offirgolan Are you sure it's going to work correctly with two async validations on the same time (let say user and email uniqueness) ? I think one might be debouncing the other one. Instead they should be running in parallel. |
|
I dont think they should interfere since the debounce context is the validator BUT I could be wrong. Can you test this out? If not I can test it out sometime this weekend. |
|
@estshy after some digging, it looks like I'm correct 😛 https://github.com/ebryn/backburner.js/blob/master/lib/backburner/index.js#L662 |
|
@offirgolan Correct. That's nice, always good to learn something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
resolveDebouncemethod to pass run.debounceTasks: