update to 3.1 and fix ObjectProxy extends validations bug #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
requested changes
Apr 20, 2018
addon/validations/factory.js
Outdated
| @@ -101,8 +101,8 @@ export default function buildValidations(validations = {}, globalOptions = {}) { | |||
| this._super(...arguments); | |||
|
|
|||
| // Count number of mixins to bypass super check if there is more than 1 | |||
| this[VALIDATIONS_MIXIN_COUNT] = this[VALIDATIONS_MIXIN_COUNT] || 0; | |||
| validationMixinCount = ++this[VALIDATIONS_MIXIN_COUNT]; | |||
| validationMixinCount = (this.get(VALIDATIONS_MIXIN_COUNT) || 0) + 1; | |||
There was a problem hiding this comment.
get(this, VALIDATIONS_MIXIN_COUNT)
addon/validations/factory.js
Outdated
| this[VALIDATIONS_MIXIN_COUNT] = this[VALIDATIONS_MIXIN_COUNT] || 0; | ||
| validationMixinCount = ++this[VALIDATIONS_MIXIN_COUNT]; | ||
| validationMixinCount = (this.get(VALIDATIONS_MIXIN_COUNT) || 0) + 1; | ||
| this.set(VALIDATIONS_MIXIN_COUNT, validationMixinCount); |
There was a problem hiding this comment.
set(this, VALIDATIONS_MIXIN_COUNT, validationMixinCount)
|
@danielspaniel thank you for this PR 😸. Added 2 small comments but other than that, lgtm! |
|
All set @offirgolan |
offirgolan
approved these changes
Apr 23, 2018
|
Thanks again @danielspaniel! |
|
your welcome @offirgolan |
|
@offirgolan would be open to backporting this fix to the v3.x branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where you get this error:
Assertion Failed: You attempted to access the
__VALIDATIONS_MIXIN_COUNT__property (of <(unknown mixin):ember391>).↵Since Ember 3.1, this is usually fine as you no longer need to use.get()↵to access computed properties. However, in this case, the object in question↵is a special kind of Ember object (a proxy). Therefore, it is still necessary↵to use.get('__VALIDATIONS_MIXIN_COUNT__')when you try to extend ObjectProxy with validations and the content you are proxying is an ember-data model
Changes proposed:
Tasks: