Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using this addon inside of an engine causes Route to be reopened twice #39

Closed
HeroicEric opened this issue Sep 29, 2017 · 1 comment · Fixed by #45
Closed

Using this addon inside of an engine causes Route to be reopened twice #39

HeroicEric opened this issue Sep 29, 2017 · 1 comment · Fixed by #45
Labels

Comments

@HeroicEric
Copy link
Contributor

HeroicEric commented Sep 29, 2017

When this addon is used inside of an engine, it's initializer is run twice, once for the parent app and once for the engine. This results in all of the hooks being fired twice.

For example, the queryParamsDidChange hook will run twice every time a query param changes.

I can create a demo app if you'd like.

@offirgolan offirgolan added the bug label Oct 2, 2017
@offirgolan
Copy link
Owner

That makes sense. @HeroicEric I'll investigate further. PR is always welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants