Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider shippable flag effect #1115

Open
SamBrishes opened this issue Apr 24, 2024 · 0 comments
Open

Reconsider shippable flag effect #1115

SamBrishes opened this issue Apr 24, 2024 · 0 comments
Labels
Milestone

Comments

@SamBrishes
Copy link
Collaborator

SamBrishes commented Apr 24, 2024

Just investigated further and it seems that disabling the "shippable" flag still applies shipping costs to the order. That shouldn't happen, right?

So both in the cart and in the quickcheckout I see the default shipping method price added to the total. And the shipping method selector is present.

Variants or no variants: the issue seems to persist.

When I go over the code, I see that only the is_virtual flag is used not to unset the shipping method. Is this something we can change?

Originally posted by @chocolata in #600 (comment)


Could we also review the functionality of the "shippable" flag? My clients are finding it unclear when to select this option, particularly for events or memberships. Despite unchecking the "shippable" option, the checkout process still includes shipping costs. It appears that only the "is_virtual" flag exempts an item from shipping charges, which seems counterintuitive. Could we have a look at this behavior and see if it would be beneficial to change it?

Originally posted by @chocolata in #600 (comment)

@SamBrishes SamBrishes added the bug label Apr 24, 2024
@SamBrishes SamBrishes added this to the 3.3.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant