Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n Support and Translate to German #10

Merged
merged 9 commits into from Sep 5, 2022

Conversation

pr0gr8mm3r
Copy link
Contributor

@pr0gr8mm3r pr0gr8mm3r commented Aug 14, 2022

This PR adds support for i18n on the calendar page and contributes a translation. It does not include the i18n setup and translation of the settings page.

Thanks for this awesome plugin :)

@LuisRodriguezLD
Copy link
Contributor

Thank you for your PR.
It looks great but could you add instructions on how to switch locales?

@pr0gr8mm3r
Copy link
Contributor Author

Sure. Add 'de' to locale config the backend config like so: https://docs.strapi.io/developer-docs/latest/development/admin-customization.html#configuration-options (Scroll down to "Locales")

Rebuild the admin panel, go to profile settings (click on your username in the Bottom left) and select "German" for Display language.

@LuisRodriguezLD
Copy link
Contributor

Thanks for adding the instructions but I meant having them inside the README.md

It seems like the calendar picker is not localized. (see image)
Also, what's the effort on translating the settings page as well?
I feel this could benefit a lot of users and it will be easier to add more languages

Screen Shot 2022-08-28 at 8 19 24 PM

@pr0gr8mm3r
Copy link
Contributor Author

Hm, I personally don't think it makes sense to put that in the README. As a developer you don't change that admin config because you want the calendar plugin to be in your language. You rather change it, because you want Strapi as a whole to be available in your language. Therefore, you would rather look for information on how to do that in Strapi's docs, as opposed to here.

The missing translation of the Date Picker is something that depends on Strapi's Design System to be translated. Right now, the components are not translated. Nothing I can do about that here, other than maybe waiting for this PR: strapi/design-system#688

The settings page is now fully translated.

@LuisRodriguezLD
Copy link
Contributor

LuisRodriguezLD commented Sep 3, 2022

You are right. I guess I just wanted to show somewhere that the plugin is now localized in German.
I'm good to merge once you resolve the failing action.

@pr0gr8mm3r
Copy link
Contributor Author

Lint passes now locally for me :)

@LuisRodriguezLD LuisRodriguezLD merged commit cd7144e into offset-dev:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants