Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning at moment js initialization #14

Merged
merged 2 commits into from Oct 9, 2022
Merged

Deprecation warning at moment js initialization #14

merged 2 commits into from Oct 9, 2022

Conversation

marcjoancr
Copy link
Contributor

Adding date format on moment initialization in order to prevent the following log message:

Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
Arguments: 
[0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: Sep 28, 2022, _f: undefined, _strict: undefined, _locale: [object Object]

LuisRodriguezLD and others added 2 commits September 4, 2022 22:19
Adding date format on moment initialization in order to prevent the following log message:
```
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
Arguments: 
[0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: Sep 28, 2022, _f: undefined, _strict: undefined, _locale: [object Object]
````
@LuisRodriguezLD
Copy link
Contributor

Thank you for this great PR.
Everything looks good to me but could you change the target?
I'd rather merge this into develop

Also, we are participating in https://hacktoberfest.com/ and we invite you to sign up but this is not a requirement.

@LuisRodriguezLD LuisRodriguezLD changed the base branch from master to develop October 9, 2022 02:59
@LuisRodriguezLD LuisRodriguezLD merged commit 45c24da into offset-dev:develop Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants