Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache directory should be configurable #11

Closed
kelson42 opened this issue Nov 3, 2021 · 4 comments
Closed

Cache directory should be configurable #11

kelson42 opened this issue Nov 3, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers wontfix This will not be worked on

Comments

@kelson42
Copy link

kelson42 commented Nov 3, 2021

Currently, it is not, the cache directory is in the (image) output directory. This brings problems:

  • This is not configurable and it exists various scenarios where this is not wanted
  • It is "hidden", ie. if the user does not look accurately to the fs, it can miss the fact that there is a cache (just had a user report about that).
  • The way the installer behaves is implicit

IMO the current behaviour is an appropriate default behaviour. But it should be visible/configuratble in the UI/cmd. I would propose to put it below the output directory file picker. Once the output directory has been set, configure the cache directory automatically (if not already configured manually).

This ticket is a follow of offspot/kiwix-hotspot#623.

@kelson42 kelson42 added enhancement New feature or request good first issue Good for newcomers labels Nov 3, 2021
@rgaudin
Copy link
Member

rgaudin commented Nov 3, 2021

I find a single user report not enough to trigger a UI change, especially given our window is already packed and hard to use on many screens.

I'd postpone that to the version with the UI makeover.

@kelson42
Copy link
Author

kelson42 commented Nov 3, 2021

Yes, definitly not urgent. But the way it works now is not explicit enough. I had a doubt myself. Next UI should probably have a simple and an advanced view or implement any other approach to not display all the options.

@stale
Copy link

stale bot commented Jan 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42 kelson42 transferred this issue from offspot/kiwix-hotspot Oct 16, 2022
@rgaudin
Copy link
Member

rgaudin commented Oct 17, 2022

Closing this as useless given we have no cache feature yet and there's already #1 that covers it.

@rgaudin rgaudin closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2022
@rgaudin rgaudin added the wontfix This will not be worked on label Oct 17, 2022
@rgaudin rgaudin self-assigned this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants