Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the Icon tab #1

Closed
ogaclejapan opened this issue Mar 31, 2015 · 4 comments
Closed

Support the Icon tab #1

ogaclejapan opened this issue Mar 31, 2015 · 4 comments
Labels
enhancement
Milestone
1.1.0

Comments

@ogaclejapan
Copy link
Owner

No description provided.

@ogaclejapan ogaclejapan added this to the 1.1.0 milestone Mar 31, 2015
@jjhesk
Copy link

jjhesk commented Apr 1, 2015

lets support generic textview that people can using their own text view extended from textview inside the tab.

@jjhesk
Copy link

jjhesk commented Apr 1, 2015

that would be awesome to add frame around each tab.

ogaclejapan added a commit that referenced this issue Apr 5, 2015
@ogaclejapan
Supported Icon Tab. #1
4815dc9 
* Implement TabProvider
* Add sample of icon tab to demo app
* Add sample of indicator trick2 to demo app
@ogaclejapan
Copy link
Owner Author

Hi, @jjhesk

I tried to implement.
What do you think about the implementation?

@ogaclejapan
Copy link
Owner Author

Merged.

ogaclejapan added a commit that referenced this issue Jul 21, 2015
@ogaclejapan
Merge pull request #50 from satorufujiwara/feature/gh-1
c074a0b 
Fix bug when tabHost has only two tabs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@jjhesk @ogaclejapan