Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you be interested in having a Dockerfile for development? #1225

Closed
AgustinRamiroDiaz opened this issue Aug 1, 2023 · 4 comments
Closed

Comments

@AgustinRamiroDiaz
Copy link

I could work on a dockerfile/docker-compose to isolate development if it's something you'd like in the repo :)

Maybe it's also useful to create releases to different targets 🤔

We can even do a dev-container for vscode (https://code.visualstudio.com/docs/devcontainers/containers)

@ariasuni
Copy link
Collaborator

ariasuni commented Aug 3, 2023

Well in general I don’t see the point, but in exa we use Vagrant for tests involving specific directory structures, locales, etc. I wanted to transition the Vagrantfile to a Dockerfile to be able to run these «xtests» that already exist, but I didn’t have the time. That would be great to have that!

@AgustinRamiroDiaz
Copy link
Author

Awesome! I'll work on it :D

@AgustinRamiroDiaz
Copy link
Author

Hey @ariasuni!

quick question: are Vagrant tests passing with the latest master commit?

I don't see any CI with Vagrant to check this, and couldn't make Vagrant work in my PC :(

I have been able to do a PoC of the Dockerfile and I could execute the tests, but there's a lot of formatting errors. I want to know if this errors are a misconfiguration of mine or if they are actually failing in master

@ariasuni
Copy link
Collaborator

Closing this since exa is unmaintained (see #1243), you should take a look at the active fork eza (an alternative strategy has been used for tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants