Tests fail when not connected to a terminal

[ignatenkobrain]

---- options::test::oneline_across stdout ----
	thread 'options::test::oneline_across' panicked at 'called `Result::unwrap_err()` on an `Ok` value: (Options { dir_action: List, filter: FileFilter { list_dirs_first: false, sort_field: Name(AaBbCc), reverse: false, dot_filter: JustFiles, ignore_patterns: IgnorePatterns { patterns: [] }, git_ignore: Off }, view: View { mode: Lines, colours: Colours { colourful: false, scale: false, filekinds: FileKinds { normal: Style {}, directory: Style {}, symlink: Style {}, pipe: Style {}, block_device: Style {}, char_device: Style {}, socket: Style {}, special: Style {}, executable: Style {} }, perms: Permissions { user_read: Style {}, user_write: Style {}, user_execute_file: Style {}, user_execute_other: Style {}, group_read: Style {}, group_write: Style {}, group_execute: Style {}, other_read: Style {}, other_write: Style {}, other_execute: Style {}, special_user_file: Style {}, special_other: Style {}, attribute: Style {} }, size: Size { numbers: Style {}, unit: Style {}, major: Style {}, minor: Style {}, scale_byte: Style {}, scale_kilo: Style {}, scale_mega: Style {}, scale_giga: Style {}, scale_huge: Style {} }, users: Users { user_you: Style {}, user_someone_else: Style {}, group_yours: Style {}, group_not_yours: Style {} }, links: Links { normal: Style {}, multi_link_file: Style {} }, git: Git { new: Style {}, modified: Style {}, deleted: Style {}, renamed: Style {}, typechange: Style {} }, punctuation: Style {}, date: Style {}, inode: Style {}, blocks: Style {}, header: Style {}, symlink_path: Style {}, broken_arrow: Style {}, broken_filename: Style {}, control_char: Style {} }, style: FileStyle { classify: JustFilenames, exts: NoFileColours } } }, [])', src/libcore/result.rs:906:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.
---- options::view::test::views::across stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::across' panicked at 'assertion failed: false', src/options/view.rs:526:8
---- options::view::test::views::empty stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::empty' panicked at 'assertion failed: false', src/options/view.rs:521:8
---- options::view::test::views::gracross stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::gracross' panicked at 'assertion failed: false', src/options/view.rs:527:8
---- options::view::test::views::grid stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::grid' panicked at 'assertion failed: false', src/options/view.rs:525:8
---- options::view::test::views::just_binary stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::just_binary' panicked at 'assertion failed: false', src/options/view.rs:548:8
---- options::view::test::views::just_blocks stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::just_blocks' panicked at 'assertion failed: false', src/options/view.rs:547:8
---- options::view::test::views::just_bytes stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::just_bytes' panicked at 'assertion failed: false', src/options/view.rs:549:8
---- options::view::test::views::just_git stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::just_git' panicked at 'assertion failed: false', src/options/view.rs:552:8
---- options::view::test::views::just_header stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::just_header' panicked at 'assertion failed: false', src/options/view.rs:543:8
---- options::view::test::views::just_group stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::just_group' panicked at 'assertion failed: false', src/options/view.rs:544:8
---- options::view::test::views::just_inode stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::just_inode' panicked at 'assertion failed: false', src/options/view.rs:545:8
---- options::view::test::views::just_links stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::just_links' panicked at 'assertion failed: false', src/options/view.rs:546:8
---- options::view::test::views::leg stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::leg' panicked at 'assertion failed: false', src/options/view.rs:539:8
---- options::view::test::views::original_g stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::original_g' panicked at 'assertion failed: false', src/options/view.rs:524:8
---- options::view::test::views::lid stdout ----
	Testing Ok(Lines)
thread 'options::view::test::views::lid' panicked at 'assertion failed: false', src/options/view.rs:538:8
failures:
    options::test::oneline_across
    options::view::test::views::across
    options::view::test::views::empty
    options::view::test::views::gracross
    options::view::test::views::grid
    options::view::test::views::just_binary
    options::view::test::views::just_blocks
    options::view::test::views::just_bytes
    options::view::test::views::just_git
    options::view::test::views::just_group
    options::view::test::views::just_header
    options::view::test::views::just_inode
    options::view::test::views::just_links
    options::view::test::views::leg
    options::view::test::views::lid
    options::view::test::views::original_g
test result: FAILED. 368 passed; 16 failed; 4 ignored; 0 measured; 0 filtered out

Not sure how to debug that...

[ogham]

This is weird! When I read "some tests fail", I thought you'd stumbled into some weird OS behaviour, or an edge case in file names, or a security permissions issue, or something like that...

But your failing tests are options parsing tests which are basically just pure functions!

I did notice something suspicious, though. The only tests that are failing here are the ones that work out how to format the output, and they're all coming back as Ok(Lines) instead of the intended result. And the Lines type is the one used when standard output isn't connected to a terminal, because it doesn't depend on width.

Sure enough:

Turns out the tests fail when they're not connected to a terminal! I had no idea. I'm guessing you're running the tests from inside another program, such as an IDE or a text editor?

I think I know how to fix this, but it's messy: mock out the "terminal width getter" code for tests, and use the actual term_size crate when actually running. I thought I could get away without doing this, but apparently not.

[ignatenkobrain]

I'm running them as part of building exa's RPM since I've packaged exa for Fedora. And yeah, it runs without tty.

[mssun]

I have the same issue. It 's easy to reproduce:

cargo test  > test.txt
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running target/debug/deps/exa-2bd4cc43b44a5d95
error: test failed, to rerun pass '--lib'

The file with stdout is attached:
test.txt

[sylvestre]

Also happening in the Debian CI: http://bugs.debian.org/917225

[sylvestre]

For posterity, I just disabled the tests:
https://salsa.debian.org/rust-team/debcargo-conf/blob/master/src/exa/debian/patches/disable-test-bug-917225.diff and the CI is much happier: https://buildd.debian.org/status/package.php?p=rust-exa&suite=sid

[jsoo1]

I just bumped into this packaging for guix. I guess I will disable the offending tests for now.

[ogham]

I just commited (not merged yet) a big refactor to the way options parsing is done. It no longer looks up the terminal width during options parsing, instead doing it later, so all the tests are now testing pure functions that aren't dependent on their environment. cargo test | cat even works.

So this issue is not long for this world