Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some ESC codes #17

Closed
bestouff opened this issue Jul 4, 2016 · 4 comments
Closed

fix some ESC codes #17

bestouff opened this issue Jul 4, 2016 · 4 comments
Assignees

Comments

@bestouff
Copy link

bestouff commented Jul 4, 2016

Hi,

According to various docs on the web, and to some tests I did on GNOME-terminal and XTerm, some of the codes you use are wrong. Could you fix them ?

  • 6 is another blink (useless)
  • 7 is reverse
  • 8 is hidden

I can do a PR if you prefer.

@ogham ogham self-assigned this Jul 4, 2016
@ogham
Copy link
Owner

ogham commented Jul 4, 2016

We might be hitting the limits of which terminals support what! I know that I've seen number 6 (blink) actually rendered as reverse on terminals that don't support it. But you're right in that it should really support the standard, if there is one.

I'm at work atm so can't re-test on the ones I was using (OS X Terminal and iTerm) until later. Will update with results.

@joshtriplett
Copy link
Collaborator

joshtriplett commented Jul 17, 2016

http://invisible-island.net/xterm/ctlseqs/ctlseqs.html (search for "CSI Pm m") doesn't list '6' at all, and it sounds like terminals differ in its interpretation, so it doesn't seem safe to use. '7' means "reverse video", and '8' means "hidden".

I'll send a pull request, which I've tested locally with multiple terminals.

@ogham
Copy link
Owner

ogham commented Jul 19, 2016

This will be released in v0.8.0

@ogham ogham closed this as completed Jul 19, 2016
@bestouff
Copy link
Author

Perfect thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants