New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some ESC codes #17
Comments
We might be hitting the limits of which terminals support what! I know that I've seen number 6 (blink) actually rendered as reverse on terminals that don't support it. But you're right in that it should really support the standard, if there is one. I'm at work atm so can't re-test on the ones I was using (OS X Terminal and iTerm) until later. Will update with results. |
http://invisible-island.net/xterm/ctlseqs/ctlseqs.html (search for "CSI Pm m") doesn't list '6' at all, and it sounds like terminals differ in its interpretation, so it doesn't seem safe to use. '7' means "reverse video", and '8' means "hidden". I'll send a pull request, which I've tested locally with multiple terminals. |
This will be released in v0.8.0 |
Perfect thanks ! |
Hi,
According to various docs on the web, and to some tests I did on GNOME-terminal and XTerm, some of the codes you use are wrong. Could you fix them ?
I can do a PR if you prefer.
The text was updated successfully, but these errors were encountered: