Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

Stacking children #117

Closed
mshd opened this issue Oct 18, 2020 · 5 comments
Closed

Stacking children #117

mshd opened this issue Oct 18, 2020 · 5 comments
Labels

Comments

@mshd
Copy link
Collaborator

mshd commented Oct 18, 2020

I know it's probably impossible but it would be so great to have this feature

@mshd mshd added the idea label Oct 18, 2020
@ogroppo
Copy link
Owner

ogroppo commented Oct 18, 2020

Could you provide a sketch?

@mshd
Copy link
Collaborator Author

mshd commented Oct 19, 2020

I think the bigger problem is that trees tend to increase in size. Stacking will improve the space management. TreantJS was able to do it. But I know it's more tricky with React
Screenshot from 2020-10-19 22-43-30
https://dataprick.github.io/wikitree/public/?q=Q9682&level=5&type=descendants&orientation=North&lang=en

@ogroppo
Copy link
Owner

ogroppo commented Oct 19, 2020

it has nothing to do with react, you need to build the object differently and pass it to the d3-hierarchy algo that calculates the positions, so technically this could be achieved perhaps setting the sibling as a child of the previous one, then apply an extra property like _isStackedSibling so that the connection shape makes that L

@mshd
Copy link
Collaborator Author

mshd commented Nov 16, 2020

Waiting for d3/d3-hierarchy#173

@mshd
Copy link
Collaborator Author

mshd commented Nov 19, 2020

With new compact themes, this issue has become less important

@mshd mshd closed this as completed Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants