-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Type : Enable single line block char drawing (├, ─, │, └) #2
Comments
It will be refactored to using 3x3 matrix for transformations. May be it will solve issue 3 in one shot. |
It will have some DSL for support extensions drawings in future (double line, thick line). |
If it will not be have things above it will have overkill cyclomatic complexity and hard to support. |
I try it already. There is an intermediate result. See https://github.com/GulinSS/boxchareditor/commits |
But no tests yet. |
Ok, I checkout your code. I see what you are doing - but it is still far from complete. Very few of the transformation work as expected. Here is some feedback:
My skype id is tsatalos. It may be easier to connect with me directly there if you think that some of the above comments are not clear. |
Thanks for feedback! All your instructions will be applied. Some updates: https://github.com/GulinSS/boxchareditor/commits/gh-pages Draft works, play :-) |
I just played with it. More of the transformations work now. You should probably revert Can you connect with me on skype to iterate a bit faster? My skype id is tsatalos. |
Html page should contains Content-Type, I added this. Probably now HTML-page looks like it was.
It works but tricky: you should delete a corner and press left/right on blank corner to get nice close. |
Sourced @oDesk for $100 - Job Completed Successfully
Add a type that uses
├
,─
,│
,└
etc chars instead of the regular bar|
, dash-
and plus+
.Note that in this case we have 11 chars (4 corner chars, 4 T chars and the
+
|
,-
.)List of chars
http://en.wikipedia.org/wiki/Box-drawing_character
All the code should be included in a new file
blocklines.js
that implements the update function.You will extend the
drawingengine.js
code below...to use the new block characters :
To simplify things I have put in this issue only single line drawing (introduction of the double line characters in the
blocklines.js
is part of a separate issue #3 ).You will also need to add a test file (similar to what exists now
test/test1.js
for thesimple
type). You should at least reproduce the existing 8 tests (with the new characters). You may need to add more to maintain the current 100% code coverage by the tests.When testing the project from the web interface, entering
block
in thetype
fieldand then pressing therestart
button should switch to the new type. At that point I should be able to "draw" using the arrow keys. Attempting to create a double should have no effect - a single line would appear instead.Follow the instructions in the README.md for making changes.
The text was updated successfully, but these errors were encountered: