Install fails on macOS #379

onbjerg · 2016-08-07T18:06:49Z

Here's my versions:

onbjerg@gh0st ~> git --version
git version 2.9.1
onbjerg@gh0st ~> fish --version
fish, version 2.2.0
onbjerg@gh0st ~> uname -a
Darwin gh0st 15.5.0 Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64

Log:

onbjerg@gh0st ~> curl -L https://github.com/oh-my-fish/oh-my-fish/raw/master/bin/install | fish
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   140  100   140    0     0    203      0 --:--:-- --:--:-- --:--:--   202
100  4693  100  4693    0     0   5323      0 --:--:-- --:--:-- --:--:--  5323
Installing Oh My Fish to /Users/onbjerg/.local/share/omf...
Cloning master from https://github.com/oh-my-fish/oh-my-fish.git...
Existent config.fish found at /Users/onbjerg/.config/fish
↳ Moving to /Users/onbjerg/.config/fish/config.1470592971.copy
Adding startup code to fish config file...
Building Oh My Fish configuration...
Illegal command name '{$OMF_CONFIG,$OMF_PATH}/pkg/*/key_bindings.fish'
~/.local/share/omf/init.fish (line 33):                       {$OMF_CONFIG,$OMF_PATH}/pkg/*/key_bindings.fish \
                                                              ^
from sourcing file ~/.local/share/omf/init.fish
        called on line 10 of file ~/.config/fish/config.fish

from sourcing file ~/.config/fish/config.fish
        called during startup

fish: Unknown command 'omf install'
fish: omf install
      ^
Oh My Fish installation failed.

If you think that it's a bug, please open an
issue with the complete installation log here:

http://github.com/oh-my-fish/oh-my-fish/issues

EDIT Updated to fish 2.3.1 and still no dice. Same error.

The text was updated successfully, but these errors were encountered:

derekstavis · 2016-08-07T18:22:11Z

This is awkward. Could you please try using the following install method to help us troubleshoot this issue?

curl -L https://raw.githubusercontent.com/oh-my-fish/oh-my-fish/installer-refactor/bin/install | fish

This is our next installer which should be delivered soon!

onbjerg · 2016-08-07T18:26:39Z

@derekstavis Thanks for the quick reply. Same issue, though.

I made sure to clear out ~/.local/share/fish and ~/.local/share/omf beforehand. I also cleared my config.fish (this is a fresh install).

onbjerg@gh0st ~> curl -L https://raw.githubusercontent.com/oh-my-fish/oh-my-fish/installer-refactor/bin/install | fish
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:100 15162  100 15162    0     0  17204      0 --:--:-- --:--:-- --:--:-- 17190
Installing Oh My Fish to /Users/onbjerg/.local/share/omf...
Cloning master from https://github.com/oh-my-fish/oh-my-fish.git...
Writing bootstrap to /Users/onbjerg/.config/fish/conf.d/omf.fish...
Building Oh My Fish configuration...
Illegal command name '{$OMF_CONFIG,$OMF_PATH}/pkg/*/key_bindings.fish'
~/.local/share/omf/init.fish (line 33):                       {$OMF_CONFIG,$OMF_PATH}/pkg/*/key_bindings.fish \
                                                              ^
from sourcing file ~/.local/share/omf/init.fish
        called on line 7 of file ~/.config/fish/conf.d/omf.fish

from sourcing file ~/.config/fish/conf.d/omf.fish
        called on line 207 of file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish

from sourcing file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish
        called during startup

source: Error while reading file '/Users/onbjerg/.local/share/omf/init.fish'
fish: Unknown command 'omf install'
fish: omf install
      ^
Install aborted: Error installing plugins

Oh My Fish installation failed.

If you think that it's a bug, please open an
issue with the complete installation log here:

http://github.com/oh-my-fish/oh-my-fish/issues

derekstavis · 2016-08-07T18:32:33Z

Cool @onbjerg, thanks for your help, this sheds some light on the error.

I have quickly pushed a branch fixing a possible issue!

Please do the following to install from that branch:

set -gx OMF_REPO_BRANCH fix-line-escape
curl -L https://raw.githubusercontent.com/oh-my-fish/oh-my-fish/installer-refactor/bin/install | fish

EDIT If the branch fixes your issue we may have found an issue in Fish parser 🍻

onbjerg · 2016-08-07T18:39:53Z

New error 😁

onbjerg@gh0st ~> curl -L https://raw.githubusercontent.com/oh-my-fish/oh-my-fish/installer-refactor/bin/install | fish
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0source: Error encountered while sourcing file '/Users/onbjerg/.local/share/omf/init.fish':
source: No such file or directory
100 15162  100 15162    0     0  28237      0 --:--:-- --:--:-- --:--:-- 28500
Installing Oh My Fish to /Users/onbjerg/.local/share/omf...
Cloning fix-line-escape from https://github.com/oh-my-fish/oh-my-fish.git...
Writing bootstrap to /Users/onbjerg/.config/fish/conf.d/omf.fish...
Building Oh My Fish configuration...
Variables may not be used as commands. In fish, please define a function or use 'eval $core_function_path'.
~/.local/share/omf/init.fish (line 17):                        $core_function_path \
                                                               ^
from sourcing file ~/.local/share/omf/init.fish
        called on line 7 of file ~/.config/fish/conf.d/omf.fish

from sourcing file ~/.config/fish/conf.d/omf.fish
        called on line 207 of file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish

from sourcing file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish
        called during startup

Variables may not be used as commands. In fish, please define a function or use 'eval $theme_function_path'.
~/.local/share/omf/init.fish (line 18):                        $theme_function_path \
                                                               ^
from sourcing file ~/.local/share/omf/init.fish
        called on line 7 of file ~/.config/fish/conf.d/omf.fish

from sourcing file ~/.config/fish/conf.d/omf.fish
        called on line 207 of file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish

from sourcing file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish
        called during startup

Variables may not be used as commands. In fish, please define a function or use 'eval $fish_function_path[2..-1]'.
~/.local/share/omf/init.fish (line 19):                        $fish_function_path[2..-1]
                                                               ^
from sourcing file ~/.local/share/omf/init.fish
        called on line 7 of file ~/.config/fish/conf.d/omf.fish

from sourcing file ~/.config/fish/conf.d/omf.fish
        called on line 207 of file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish

from sourcing file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish
        called during startup

fish: Unknown command 'require --path /Users/onbjerg/.local/share/omf/pkg/fish-spec /Users/onbjerg/.local/share/omf/pkg/omf'
~/.local/share/omf/init.fish (line 22): require --path {$OMF_PATH,$OMF_CONFIG}/pkg/*
                                        ^
from sourcing file ~/.local/share/omf/init.fish
        called on line 7 of file ~/.config/fish/conf.d/omf.fish

from sourcing file ~/.config/fish/conf.d/omf.fish
        called on line 207 of file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish

from sourcing file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish
        called during startup

fish: Unknown command 'require --no-bundle --path /Users/onbjerg/.config/omf'
~/.local/share/omf/init.fish (line 42): require --no-bundle --path $OMF_CONFIG
                                        ^
from sourcing file ~/.local/share/omf/init.fish
        called on line 7 of file ~/.config/fish/conf.d/omf.fish

from sourcing file ~/.config/fish/conf.d/omf.fish
        called on line 207 of file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish

from sourcing file /usr/local/Cellar/fish/2.3.1/share/fish/config.fish
        called during startup

fish: Unknown command 'omf install'
fish: omf install
      ^
Install aborted: Error installing plugins

Oh My Fish installation failed.

If you think that it's a bug, please open an
issue with the complete installation log here:

http://github.com/oh-my-fish/oh-my-fish/issues

Thanks for the fast fixes, really appreciate it.

derekstavis · 2016-08-07T18:49:02Z

Whoa, fish isn't interpreting new line escapes. This looks like a Fish issue with something in your system!

You may see that in the branch that I've just removed the line escapes. Now it looks the error is happening in the next line escape fish found.

I have no clue how to debug this kind of issue, but I would bet something is strange with your locale or file system.

cc. @faho @ridiculousfish, any idea on how to debug this kind of situation?

onbjerg · 2016-08-07T18:53:15Z

@derekstavis My locale isn't strange (AFAIK)

onbjerg@gh0st ~> locale
LANG="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_ALL=

I don't have issues with any other things on my system development related, so I guess that it's not my file system either. Maybe it's a setting in git (CRLF/LF)?

onbjerg@gh0st ~> git config --global core.autocrlf
true

derekstavis · 2016-08-07T18:56:47Z

Maybe it's a setting in git (CRLF/LF)?

Good idea. As code is copied using git, this is a huge possibility.

Have you done any change to git's core.autocrlf setting?

onbjerg · 2016-08-07T18:57:17Z

I don't remember. Can you check yours?

derekstavis · 2016-08-07T18:59:38Z

Mine is currently empty. You can check yours using:

git config --global --get core.autocrlf

If you have no output, it's empty too, matching my system configuration.

onbjerg · 2016-08-07T19:00:02Z

Mine is set. I'll try clearing it, hold on.

onbjerg · 2016-08-07T19:01:06Z

Damn it. That was it. Thank you so much! 😀 🎉

derekstavis · 2016-08-07T19:02:36Z

Awesome @onbjerg, thanks for helping us narrowing this issue. Now it will be much easier if someone comes with the same issue again, thank you!! 👍 🎉

derekstavis · 2016-08-07T19:06:44Z

Also @onbjerg be sure to have OMF_REPO_BRANCH variable cleaned up before running installer again. You can do it using set -e OMF_REPO_BRANCH. This will ensure your install uses master branch as source of updates 👍

onbjerg · 2016-08-07T20:40:08Z

@derekstavis Of course :) Thank you for walking through this with me.

oranja · 2016-08-08T05:56:48Z

Actually we've had the autocrlf issue before (#217). It was an OS X as well, but that's a distraction, while the dead giveaway is the ignored little backslash (\) at the end. We'll have to keep that in mind.

onbjerg mentioned this issue Aug 7, 2016

Fish 2.3.0-1 update breaks everything #340

Closed

onbjerg closed this as completed Aug 7, 2016

oranja mentioned this issue Sep 29, 2016

Error while sourcing the file #406

Closed

sagebind mentioned this issue Dec 17, 2016

Ensure Fish scripts always use LF line endings, otherwise multiline commands break #458

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install fails on macOS #379

Install fails on macOS #379

onbjerg commented Aug 7, 2016 •

edited

Loading

derekstavis commented Aug 7, 2016 •

edited

Loading

onbjerg commented Aug 7, 2016

derekstavis commented Aug 7, 2016 •

edited

Loading

onbjerg commented Aug 7, 2016

derekstavis commented Aug 7, 2016

onbjerg commented Aug 7, 2016 •

edited

Loading

derekstavis commented Aug 7, 2016

onbjerg commented Aug 7, 2016

derekstavis commented Aug 7, 2016

onbjerg commented Aug 7, 2016

onbjerg commented Aug 7, 2016

derekstavis commented Aug 7, 2016

derekstavis commented Aug 7, 2016 •

edited

Loading

onbjerg commented Aug 7, 2016

oranja commented Aug 8, 2016

Install fails on macOS #379

Install fails on macOS #379

Comments

onbjerg commented Aug 7, 2016 • edited Loading

derekstavis commented Aug 7, 2016 • edited Loading

onbjerg commented Aug 7, 2016

derekstavis commented Aug 7, 2016 • edited Loading

onbjerg commented Aug 7, 2016

derekstavis commented Aug 7, 2016

onbjerg commented Aug 7, 2016 • edited Loading

derekstavis commented Aug 7, 2016

onbjerg commented Aug 7, 2016

derekstavis commented Aug 7, 2016

onbjerg commented Aug 7, 2016

onbjerg commented Aug 7, 2016

derekstavis commented Aug 7, 2016

derekstavis commented Aug 7, 2016 • edited Loading

onbjerg commented Aug 7, 2016

oranja commented Aug 8, 2016

onbjerg commented Aug 7, 2016 •

edited

Loading

derekstavis commented Aug 7, 2016 •

edited

Loading

derekstavis commented Aug 7, 2016 •

edited

Loading

onbjerg commented Aug 7, 2016 •

edited

Loading

derekstavis commented Aug 7, 2016 •

edited

Loading