Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attribute 'class' seem doesn't work correctly with Cycle js #4

Closed
olivmonnier opened this issue Jul 18, 2015 · 3 comments
Closed

attribute 'class' seem doesn't work correctly with Cycle js #4

olivmonnier opened this issue Jul 18, 2015 · 3 comments

Comments

@olivmonnier
Copy link

i recommend to use 'className' instead of 'class'
@ohanhi
Copy link
Owner

ohanhi commented Jul 20, 2015

@staltz Could you verify?

@ohanhi
Copy link
Owner

ohanhi commented Jul 20, 2015

Actually, @oliv75, won't you try to simply use 'className'? This library is in essence a proxy to the given hyperscript implementation, so whatever works on the hyperscript library should work through hyperscript-helpers too.

@ohanhi
Copy link
Owner

ohanhi commented Aug 3, 2015

Okay, I can confirm that everything works as expected when you simply use className instead of class in Cycle. Closing the issue.
/cc @oliv75 @staltz

@ohanhi ohanhi closed this as completed Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olivmonnier @ohanhi