Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong column type in OneLocationInfo table ? should be String rather Integer? #2

Closed
binjo opened this issue Aug 17, 2010 · 2 comments
Closed

Comments

@binjo
Copy link

binjo commented Aug 17, 2010

hi,

while looking around the DarunGrimDatabaseWrapper.py, i found the following column types are different with DarunGrim2, maybe its a typo?

/DarunGrim/Src/Diff Inspector/DarunGrimDatabaseWrapper.py 18-20:
name = Column( Integer, name = "Name" )
disasm_lines = Column( Integer, name = "DisasmLines" )
fingerprint = Column( Integer, name = "Fingerprint" )

differ with DarunGrim2:
sqlite> .schema OneLocationInfo
CREATE TABLE OneLocationInfo (
id INTEGER PRIMARY KEY AUTOINCREMENT,
FileID INTEGER,
StartAddress INTEGER,
EndAddress INTEGER,
Flag INTEGER,
FunctionAddress INTEGER,
BlockType INTEGER,
Name TEXT,
DisasmLines TEXT,
Fingerprint TEXT
);

@ohjeongwook
Copy link
Owner

You're right. Luckily it was never used in the code. I'll upload fix soon.

@ohjeongwook
Copy link
Owner

Fixed

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants