-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I added Agoo to the TFB #59
Comments
The code looks pretty reasonable. The only thing I would change might be the number of workers. That is something you would have to experiment with though. I suspect the database will be the most significant bottleneck since it looked like the queries are synchronous. Spreading them out over as many separate real threads will probably give the best performance. I wonder if the connection pool make a significant difference or if more workers would give better results. Nice charts by the way. |
The charts aren't mine. I only added Agoo to the TechEmpower Framework Benchmark (TFB): TechEmpower/FrameworkBenchmarks#4709
Do you have sample code how to accomplish that? |
Just change the |
The TFB runs the actual benchmark in Docker containers. The machines which will run the benchmarks is considerably different from mine. So |
It might be better to have a multiplier on I'm not sure how the connection pool works but if it establishes 250 connections right away that could be a problem if mongo is not configured for for a large number of connections. Let me explain a little. The So I threw in another variable, didn't I. Not knowing how the drivers are implemented makes it tough to give specific values for the |
What ever happened with this? I did not see Agoo on the results page. |
No response. Closing. |
@ohler55 In case you never found it, it was added in TechEmpower/FrameworkBenchmarks#4709. Have in mind the implementation is flagged as Stripped, which means it's not shown by default, and needs to be manually enabled in the filters: |
I failed to find the implementation approach option for Stripped in the filters. All that appears is Realistic. I would love to see the results and would be glad to check the configuration to see if it is optimum. I would also like to get Agoo so it shows up with Realistic if you can point me at what to takes to earn that label. |
From the general requirements in the project:
Not familiar with how the decision is made, in this case it seems it was added as Stripped by @GertThiel. Perhaps you can make a pull request with changes to the sample app to flag it as Realistic instead. |
Thanks. I'll do that and see what the response is. |
https://github.com/GertThiel/FrameworkBenchmarks/tree/master/frameworks/Ruby/agoo
Maybe you want to have a look, maybe want to optimize?
The text was updated successfully, but these errors were encountered: