-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation fault #69
Comments
The log isn't that helpful but I will get to the bottom of the issue and get it fixed. Can you tell me more about what the app is doing? How is Agoo started? Is this Rails, Rack, something else? |
Dang, I was hoping the log would be of more use. Agoo's being started with # Requires and things here...
# HTTP Cache-Control
cache =
if Environment.cache_assets?
'public, max-age=31536000, immutable'
else
'private, no-store'
end
# Agoo configuration and start up.
Agoo::Server.init(3000, 'public', root_first: true, thread_count: 0, worker_count: 1)
# Cache rules.
Agoo::Server.header_rule('**', 'css', Rack::CACHE_CONTROL, cache)
Agoo::Server.header_rule('**', 'js', Rack::CACHE_CONTROL, cache)
Agoo::Server.header_rule('**', 'map', Rack::CACHE_CONTROL, cache)
# Allow cross-origin font requests.
Agoo::Server.header_rule('**', 'ttf', 'Access-Control-Allow-Origin', '*')
Agoo::Server.header_rule('**', 'woff', 'Access-Control-Allow-Origin', '*')
Agoo::Server.header_rule('**', 'woff2', 'Access-Control-Allow-Origin', '*')
Agoo::Server.handle(nil, '**', Engage::Application)
Agoo::Server.start The last time it segfaulted I was logging out, which just destroys the session and renders a template. |
I'll be trying to set up an app that causes the crash you encountered so any help in putting that together would help. |
I'll try and get something together too. Is there any extra debugging or logging I should have enabled for my main application that's been crashing to help diagnose the problem? |
One thing that's odd is that accessing the same path and running the same route code doesn't consistently cause a crash. I just had a crash and once I restarted the server, the same request worked fine. Here's the crash log from ~/Library/logs/DiagnosticReports
I don't really know what I'm looking at there, but these three lines seemed interesting:
And |
Not much of that means much to me either but you did bring up a good point. You can turn on additional logging. That might help. I can add more debug information or maybe a trace logging feature to tell us everything that goes on. I might make that a compile option though if it slows things down too much. I'm going to be doing some traveling soon so my time on this may be limited for a week or so. If I can reproduce the issue before Friday I'll have some flight time to work on it otherwise I'll focus on tracing. |
I think I've narrowed it down but I haven't had a chance to put together a code base to reproduce it yet, I'll try to get that done today. I use a script called instantpage on my site that attempts to preload pages with a I'll work on a repro this afternoon and see if I can narrow it further. |
Good detective work. |
It's not quite as predictable as I'd like, calling |
Cool, thanks. I hit it tomorrow. |
Excellent. I got it to fail! |
Narrowing it down. The issue is around the closing of the connection. Just a status update :-) |
Awesome, thanks for digging into it so quickly! |
I have a plan but it will take a bit. I'll make the fix on the plane Friday and get it out in a branch for you to test over the weekend. |
Please try the |
Looks good to me, I can't reproduce the problem with my little reproduction repo. |
Great I'll make a release later today then. |
I'm not 100% sure that this is an issue with Agoo, but I never encountered segfaults with Puma and they only started showing up after I switched. I can't seem to reliably reproduce the problem, but seemingly random navigation around my app will segfault and crash the server.
Here's the segfault crash log
I left off the loaded features because it's like 1100 lines but I'm happy to add them here if it'd help. Is there anything you can glean from this crash log? Is it possible that this has nothing to do with Agoo?
Thanks for taking a look, I appreciate it!
The text was updated successfully, but these errors were encountered: