Oj.load second argument unconditionally assumes hash

[enebo]

ruby -roj -e 'Oj.load("sss", nil)'

Glancing at the code and this is just missing a Check_Type (or rb_check_type). Actually, the check is in other functions:

    if (T_HASH != rb_type(ropts)) {
        rb_raise(rb_eArgError, "options must be a hash.");
    }

load_file is also missing this check.

[ohler55]

I'll get that fixed this week.

[enebo]

@ohler55 cool. although not a crasher (and not this reported issue) I think you also do some manual checks for T_FIXNUM and then follow up with a second Check_Type in a couple of places. I think with Check_Type second it is redundant (if it was before it might to_int -- I don't recall offhand).

[ohler55]

I'll look for those. No need to do the check twice.

[ohler55]

Please check the latest version on github. If it looks good I will make a release.

[enebo]

@ohler55 yeah I only noticed the two missing hash checks and have not seen any others.

[ohler55]

Try it with the latest 2.12.13 release.