Skip to content

Commit

Permalink
Style CI fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
gnikyt committed Oct 19, 2018
1 parent f094144 commit 313e322
Show file tree
Hide file tree
Showing 17 changed files with 47 additions and 54 deletions.
4 changes: 1 addition & 3 deletions src/OhMyBrew/BasicShopifyResource/Models/Collect.php
Expand Up @@ -2,10 +2,8 @@

namespace OhMyBrew\BasicShopifyResource\Models;

use OhMyBrew\BasicShopifyResource\Resource;
use OhMyBrew\BasicShopifyResource\Relationships\HasOne;
use OhMyBrew\BasicShopifyResource\Models\Product;
use OhMyBrew\BasicShopifyResource\Models\CustomCollection;
use OhMyBrew\BasicShopifyResource\Resource;

/**
* Custom Collection API.
Expand Down
Expand Up @@ -2,8 +2,8 @@

namespace OhMyBrew\BasicShopifyResource\Models;

use OhMyBrew\BasicShopifyResource\Resource;
use OhMyBrew\BasicShopifyResource\Relationships\HasMany;
use OhMyBrew\BasicShopifyResource\Resource;

/**
* Custom Collection API.
Expand Down
2 changes: 1 addition & 1 deletion src/OhMyBrew/BasicShopifyResource/Models/Image.php
Expand Up @@ -2,8 +2,8 @@

namespace OhMyBrew\BasicShopifyResource\Models;

use OhMyBrew\BasicShopifyResource\Resource;
use OhMyBrew\BasicShopifyResource\Relationships\HasOne;
use OhMyBrew\BasicShopifyResource\Resource;

/**
* Image API.
Expand Down
4 changes: 2 additions & 2 deletions src/OhMyBrew/BasicShopifyResource/Models/Product.php
Expand Up @@ -2,9 +2,9 @@

namespace OhMyBrew\BasicShopifyResource\Models;

use OhMyBrew\BasicShopifyResource\Resource;
use OhMyBrew\BasicShopifyResource\Relationships\IncludesMany;
use OhMyBrew\BasicShopifyResource\Relationships\HasMany;
use OhMyBrew\BasicShopifyResource\Relationships\IncludesMany;
use OhMyBrew\BasicShopifyResource\Resource;

/**
* Product API.
Expand Down
14 changes: 6 additions & 8 deletions src/OhMyBrew/BasicShopifyResource/Models/Variant.php
Expand Up @@ -2,11 +2,9 @@

namespace OhMyBrew\BasicShopifyResource\Models;

use OhMyBrew\BasicShopifyResource\Resource;
use OhMyBrew\BasicShopifyResource\Relationships\HasOne;
use OhMyBrew\BasicShopifyResource\Relationships\HasOneThrough;
use OhMyBrew\BasicShopifyResource\Models\Image;
use OhMyBrew\BasicShopifyResource\Models\Product;
use OhMyBrew\BasicShopifyResource\Resource;

class Variant extends Resource
{
Expand Down Expand Up @@ -50,12 +48,12 @@ function () {
'image' => (new HasOneThrough(Image::class))
->setThrough(Product::class)
->setThroughId(
/**
* @codeCoverageIgnore
*/
/**
* @codeCoverageIgnore
*/
function () {
return $this->product_id;
})
return $this->product_id;
}),
];
}
}
6 changes: 3 additions & 3 deletions src/OhMyBrew/BasicShopifyResource/Relationships/HasMany.php
Expand Up @@ -2,6 +2,6 @@

namespace OhMyBrew\BasicShopifyResource\Relationships;

use OhMyBrew\BasicShopifyResource\Relationships\Relationship;

class HasMany extends Relationship { }
class HasMany extends Relationship
{
}
6 changes: 3 additions & 3 deletions src/OhMyBrew/BasicShopifyResource/Relationships/HasOne.php
Expand Up @@ -2,6 +2,6 @@

namespace OhMyBrew\BasicShopifyResource\Relationships;

use OhMyBrew\BasicShopifyResource\Relationships\Relationship;

class HasOne extends Relationship { }
class HasOne extends Relationship
{
}
Expand Up @@ -3,7 +3,6 @@
namespace OhMyBrew\BasicShopifyResource\Relationships;

use Closure;
use OhMyBrew\BasicShopifyResource\Relationships\Relationship;

class HasOneThrough extends Relationship
{
Expand Down
Expand Up @@ -2,6 +2,6 @@

namespace OhMyBrew\BasicShopifyResource\Relationships;

use OhMyBrew\BasicShopifyResource\Relationships\Relationship;

class IncludesMany extends Relationship { }
class IncludesMany extends Relationship
{
}
Expand Up @@ -2,6 +2,6 @@

namespace OhMyBrew\BasicShopifyResource\Relationships;

use OhMyBrew\BasicShopifyResource\Relationships\Relationship;

class IncludesOne extends Relationship { }
class IncludesOne extends Relationship
{
}
26 changes: 13 additions & 13 deletions src/OhMyBrew/BasicShopifyResource/Resource.php
Expand Up @@ -3,12 +3,12 @@
namespace OhMyBrew\BasicShopifyResource;

use Exception;
use Tightenco\Collect\Support\Collection;
use OhMyBrew\BasicShopifyResource\Relationships\IncludesMany;
use OhMyBrew\BasicShopifyResource\Relationships\IncludesOne;
use OhMyBrew\BasicShopifyResource\Relationships\HasMany;
use OhMyBrew\BasicShopifyResource\Relationships\HasOne;
use OhMyBrew\BasicShopifyResource\Relationships\HasOneThrough;
use OhMyBrew\BasicShopifyResource\Relationships\IncludesMany;
use OhMyBrew\BasicShopifyResource\Relationships\IncludesOne;
use Tightenco\Collect\Support\Collection;

/**
* Resource class which all models are based on.
Expand Down Expand Up @@ -218,7 +218,7 @@ public static function allThrough($resource, array $params = [])
* @param int $resourceId The ID of the resource.
* @param array $params Additional param to pass with the request.
*
* @return Resource
* @return resource
*/
public static function find($resourceId, array $params = [])
{
Expand All @@ -233,7 +233,7 @@ public static function find($resourceId, array $params = [])
* @param object|string $throughResource The resource to loop through
* @param array $params Additional param to pass with the request.
*
* @return Resource
* @return resource
*/
public static function findThrough($resourceId, $throughResource, array $params = [])
{
Expand All @@ -245,10 +245,10 @@ public static function findThrough($resourceId, $throughResource, array $params
* Relationship of includesOne.
* This resource includes a single nested resource.
*
* @param string $resource The class name of the resource.
* @param array $params Additional param to pass with the request.
* @param string $resource The class name of the resource.
* @param array $params Additional param to pass with the request.
*
* @return Resource
* @return resource
*/
public function includesOne($resource, array $params = [])
{
Expand All @@ -257,7 +257,7 @@ public function includesOne($resource, array $params = [])
$id = $instance->{$instance->resourceName_id};

if ($id === null) {
return null;
return;
}

return $instance::find($id, $params);
Expand Down Expand Up @@ -303,7 +303,7 @@ public function hasMany($resource, array $params)
* @param string $resource The class name of the resource.
* @param array $params Additional param to pass with the request.
*
* @return Resource
* @return resource
*/
public function hasOne($resource, array $params)
{
Expand All @@ -322,16 +322,16 @@ public function hasOne($resource, array $params)
* @param string $throughResource The through resource class.
* @param int $throughId Through resource ID.
*
* @return Resource
* @return resource
*/
public function hasOneThrough($resource, array $params = [], $throughResource, $throughId)
public function hasOneThrough($resource, array $params, $throughResource, $throughId)
{
$instance = new $resource();
$throughInstance = new $throughResource();
$id = $this->{"{$instance->resourceName}_id"};

if ($id === null) {
return null;
return;
}

return $instance::findThrough($id, $throughInstance::find($throughId), $params);
Expand Down
4 changes: 2 additions & 2 deletions test/Models/CollectTest.php
Expand Up @@ -2,10 +2,10 @@

namespace OhMyBrew\BasicShopifyResource\Test\Models;

use OhMyBrew\BasicShopifyResource\Test\TestCase;
use OhMyBrew\BasicShopifyResource\Models\Collect;
use OhMyBrew\BasicShopifyResource\Models\CustomCollection;
use OhMyBrew\BasicShopifyResource\Models\Product;
use OhMyBrew\BasicShopifyResource\Test\TestCase;
use Tightenco\Collect\Support\Collection;

class CollectTest extends TestCase
Expand Down Expand Up @@ -53,4 +53,4 @@ public function testRelationships()
$collection = $collect->collection;
$this->assertInstanceOf(CustomCollection::class, $collection);
}
}
}
6 changes: 2 additions & 4 deletions test/Models/CustomCollection.php
Expand Up @@ -2,12 +2,10 @@

namespace OhMyBrew\BasicShopifyResource\Test\Models;

use OhMyBrew\BasicShopifyResource\Models\Product;
use OhMyBrew\BasicShopifyResource\Models\Image;
use OhMyBrew\BasicShopifyResource\Test\TestCase;
use Tightenco\Collect\Support\Collection;

class CustomCollectionTest extends TestCase
class CustomCollection extends TestCase
{
public function testSetup()
{
Expand Down Expand Up @@ -48,4 +46,4 @@ public function testRelationships()
$collects = $collection->collects;
$this->assertInstanceOf(Collection::class, $collects);
}
}
}
4 changes: 2 additions & 2 deletions test/Models/ImageTest.php
Expand Up @@ -2,8 +2,8 @@

namespace OhMyBrew\BasicShopifyResource\Test\Models;

use OhMyBrew\BasicShopifyResource\Models\Product;
use OhMyBrew\BasicShopifyResource\Models\Image;
use OhMyBrew\BasicShopifyResource\Models\Product;
use OhMyBrew\BasicShopifyResource\Test\TestCase;
use Tightenco\Collect\Support\Collection;

Expand Down Expand Up @@ -48,4 +48,4 @@ public function testRelationships()
$product = $image->product;
$this->assertInstanceOf(Product::class, $product);
}
}
}
2 changes: 1 addition & 1 deletion test/Models/ProductTest.php
Expand Up @@ -63,4 +63,4 @@ public function testRelationships()
$this->assertInstanceOf(Collection::class, $collects);
$this->assertTrue($collects->count() > 0);
}
}
}
4 changes: 2 additions & 2 deletions test/Models/VariantTest.php
Expand Up @@ -2,9 +2,9 @@

namespace OhMyBrew\BasicShopifyResource\Test\Models;

use OhMyBrew\BasicShopifyResource\Models\Image;
use OhMyBrew\BasicShopifyResource\Models\Product;
use OhMyBrew\BasicShopifyResource\Models\Variant;
use OhMyBrew\BasicShopifyResource\Models\Image;
use OhMyBrew\BasicShopifyResource\Test\TestCase;
use Tightenco\Collect\Support\Collection;

Expand Down Expand Up @@ -61,4 +61,4 @@ public function testRelationships()
$image = $variant->image;
$this->assertInstanceOf(Image::class, $image);
}
}
}
4 changes: 2 additions & 2 deletions test/TestCase.php
Expand Up @@ -2,12 +2,12 @@

namespace OhMyBrew\BasicShopifyResource\Test;

use ReflectionClass;
use ReflectionProperty;
use GuzzleHttp\Client;
use GuzzleHttp\Handler\MockHandler;
use GuzzleHttp\Psr7\Response;
use OhMyBrew\BasicShopifyResource\Connection;
use ReflectionClass;
use ReflectionProperty;

abstract class TestCase extends \PHPUnit\Framework\TestCase
{
Expand Down

0 comments on commit 313e322

Please sign in to comment.