Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect $ZDOTDIR in uninstaller #11466

Open
mcornella opened this issue Jan 29, 2023 · 0 comments
Open

Respect $ZDOTDIR in uninstaller #11466

mcornella opened this issue Jan 29, 2023 · 0 comments
Assignees
Labels
Area: uninstaller Issue or PR related to the uninstaller Bug Something isn't working

Comments

@mcornella
Copy link
Member

Describe the bug

Uninstaller does not respect the actual install directory (#10537) and it won't respect the .zshrc location if installed on a different directory using $ZDOTDIR.

Steps to reproduce

  1. Create ZDOTDIR directory if not yet created: mkdir -p ~/.config/zsh
  2. Install OMZ in custom ZDOTDIR: ZDOTDIR=~/.config/zsh sh install.sh
  3. Run uninstall_oh_my_zsh
  4. .zshrc and $ZSH folder are not removed

Expected behavior

  • Correct OMZ folder is removed
  • .zshrc file is looked for in $ZDOTDIR

Screenshots and recordings

$ uninstall_oh_my_zsh 
Are you sure you want to remove Oh My Zsh? [y/N] y
Removing ~/.oh-my-zsh
Looking for original zsh config...
No original zsh config found
Thanks for trying out Oh My Zsh. It's been uninstalled.
Don't forget to restart your terminal!

OS / Linux distribution

Any

Zsh version

Any

Oh My Zsh version

master (b2313ec)

Terminal emulator

Any

If using WSL on Windows, which version of WSL

None

Additional context

No response

@mcornella mcornella added the Bug Something isn't working label Jan 29, 2023
@mcornella mcornella self-assigned this Jan 29, 2023
@mcornella mcornella added the Area: uninstaller Issue or PR related to the uninstaller label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: uninstaller Issue or PR related to the uninstaller Bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant