Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rude installation behaviour #4831

Closed
slavaGanzin opened this issue Feb 6, 2016 · 3 comments
Closed

Rude installation behaviour #4831

slavaGanzin opened this issue Feb 6, 2016 · 3 comments

Comments

@slavaGanzin
Copy link
Contributor

Guys, I appreciate your work, but what your installer should do is adding

echo "#Some silly comment
  export ZSH=/home/vganzin/.oh-my-zsh
  source $ZSH/oh-my-zsh.sh" >> .zshrc

And not rewriting my precious .zshrc without even questioning about.

@sanyocc
Copy link

sanyocc commented Feb 6, 2016

lol I agree. "Rude" is the best definition. But I believe that this behavior is not without reason.

@mcornella
Copy link
Member

First of all, I agree with the general sentiment there. The installer is one of many pain points of Oh My Zsh, and we're tracking it's many issues at #4355 as well as accepting suggestions at #4393.

That said, the proposed behavior would not be without its issues, the main one being that user configurations would be done before loading Oh My Zsh, and possibly get overwritten by OMZ settings. A possible alternative would be to put that at the top of the zshrc file.

Possibly we implement some kind of alternative in the next version of the installer, so that the user can choose between using the full zshrc template or using this simpler method.

@slavaGanzin
Copy link
Contributor Author

Closing as duplicate of #4390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants