Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker container run --g[TAB] no --gpus completion for zsh #8972

Closed
yantaozhao opened this issue May 29, 2020 · 3 comments · Fixed by #9470
Closed

docker container run --g[TAB] no --gpus completion for zsh #8972

yantaozhao opened this issue May 29, 2020 · 3 comments · Fixed by #9470
Labels
Feature New feature or request

Comments

@yantaozhao
Copy link
Contributor

Is your feature request related to a particular plugin or theme? If so, specify it.
The name of the plugin that you would like us to improve: docker

Is your feature request related to a problem? Please describe.
In zsh shell prompt, input docker container run --g[TAB][TAB], there's no --gpus completion shows in the candidates.

Describe the solution you'd like
the docker plugin in ohmyzsh comes from docker-cli , and the upstreaming docker cli seems not work properly with docker container run --gpus ... completion too. I've already file an issue in the docker cli official repo.
Perhaps it should update the docker cli official repo, and then sync the ohmyzsh docker plugin.

@yantaozhao yantaozhao added the Feature New feature or request label May 29, 2020
@mcornella
Copy link
Member

I'll close this until there's a fix upstream.

@yantaozhao
Copy link
Contributor Author

I'll close this until there's a fix upstream.

the upstream has been updated.

@mcornella
Copy link
Member

Updated in #9470.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants