killdir error message when exporting mac os x package from distribute game

[ohrrpgce-bugbot]

[sf#2025]

When you export a Mac OS X app from the Distribute Game menu, there is an error message that says:

"killdir: refusing to delete directory '/home/james/.ohrrpgce/_gameplayer/OHRRPGCE-Game.app'"

https://i.imgur.com/581gPy4.png

As far as I can tell, this error does not actually break anything, it is just annoying (?)

I am guessing that this was probably the only code that actually relied on killdir's recently eliminated recursive delete feature.

From: @bob-the-hamster
Reported version: Nightly WIP (Dwimmercrafty)
Operating system: Linux

[rversteegen]

Actually, recursive deletion was never removed from killdir. That error message was added in r7997 (24e91ed)

+  ' For safety. (You ought to pass absolute paths.) Check
+  ' writability so we don't recurse if started from e.g. /home until
+  ' we hit something deletable (this happened to me)!
+  IF LEN(directory) < 5 ORELSE diriswriteable(directory) = NO THEN
+   showerror "killdir: refusing to delete directory '" & directory & "'"
+   EXIT SUB
+  END IF

(Since reworded to "killdir: refusing suspicious attempt to delete directory")

But no sign of the error now, 3 1/2 years later, so I'll close this.