Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Self"- and "Ally not Self"-target attacks are treated as "Ally"-target attacks out of battle. #1105

Closed
NathanWeasel opened this issue Mar 14, 2020 · 1 comment
Labels
attacks bug Yeah... that's broken

Comments

@NathanWeasel
Copy link

Characters with spells that are only supposed to be able to heal themselves can instead be used as general-purpose ally healing spells when used out of battle, probably due to overlap with the potential of such being called from items (where it makes sense to be able to choose which hero to use them on)

@rversteegen rversteegen changed the title "Self"-target attacks are treated as "Ally"-target attacks out of battle. "Self"- and "Ally not Self"-target attacks are treated as "Ally"-target attacks out of battle. Mar 15, 2020
@rversteegen
Copy link
Contributor

"Ally Not Self" is also broken. Mefisno reported that a while ago.

Out of battle, nearly all target classes are treated as being equivalent to "Ally". If we didn't, anything that targeted enemies or previous attackers wouldn't be usable. Don't see much of an alternative to that. Of course those attacks probably aren't useful anyway. But "Self" and "Ally Not Self" can be respected.

chkOOBtag needs to be extended. Currently, it checks only whether heroes are targettable due to being dead -- so "Ally (including dead)" and "Dead Allies" work.

@rversteegen rversteegen added attacks bug Yeah... that's broken labels Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attacks bug Yeah... that's broken
Projects
None yet
Development

No branches or pull requests

2 participants