Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx_sdl2 doesn't recenter when the window zoom is changed #1188

Closed
rversteegen opened this issue Jan 13, 2021 · 1 comment
Closed

gfx_sdl2 doesn't recenter when the window zoom is changed #1188

rversteegen opened this issue Jan 13, 2021 · 1 comment
Labels
bug Yeah... that's broken gfx_sdl2 Specific to the SDL 2 graphics/IO backend minor Cosmetic or easily ignored issues

Comments

@rversteegen
Copy link
Contributor

kylekrack and Ravancloak complained that unlike gfx_sdl, gfx_sdl2 does not recenter the window when you change its zoom (from F9 or Cmd-1/2/3/4). Instead the top-left corner remains fixed.

This is because gfx_sdl2_recenter_window_hint called from gfx_sdl2_set_window_size does nothing, because the window isn't recreated, unlike gfx_sdl. Need to manually tell the window to recenter.

@rversteegen rversteegen added needs improvement It ain't completely broken... but it ain't quite the way it should be yet gfx_sdl2 Specific to the SDL 2 graphics/IO backend minor Cosmetic or easily ignored issues labels Jan 13, 2021
@rversteegen
Copy link
Contributor Author

Fixed in r12419 (6fca195)

@rversteegen rversteegen added bug Yeah... that's broken and removed needs improvement It ain't completely broken... but it ain't quite the way it should be yet labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Yeah... that's broken gfx_sdl2 Specific to the SDL 2 graphics/IO backend minor Cosmetic or easily ignored issues
Projects
None yet
Development

No branches or pull requests

1 participant