Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Store target attack bitset can store multiple targets #1206

Closed
CronosZX opened this issue Jul 30, 2021 · 3 comments
Closed
Labels
attacks resolved: invalid Not a real bug report/feature request

Comments

@CronosZX
Copy link

As far as I'm aware the Store target bitset can only store store one target if the attack used for it has spread or optional spread targeting.
This would be extremely useful useful for attacks that change target in the middle of the chain (casting animation on caster/altering stats/etc) as those are currently limited to single target only because of this limitation with the store target bitset.

@CronosZX CronosZX changed the title Feature: Store target attack bitset can store multiple targets Feature request: Store target attack bitset can store multiple targets Jul 30, 2021
@bob-the-hamster
Copy link
Collaborator

Stored target should already be capable of storing multiple targets
Try this:

  • Attack 1 is optional spread, and stores target
  • Attack 2 is spread, and uses target class "stored target"

Because stored targets are used as a target class, attacks that make use of the stored target should usually always be "spread" so they will pick all of the stored targets.

@rversteegen
Copy link
Contributor

Yes, in fact the stored targets is a mask over all heroes/enemies, and Store Target doesn't set the stored target, it adds all the attack's targets to the current mask. Reset Target clears the mask. Unfortunately, combining Store Target with Reset Target is broken, see bug #42.

Did you find something confusing in the documentation? Or did it not seem to work for multiple targets when you tried it?

@rversteegen rversteegen added attacks resolved: invalid Not a real bug report/feature request labels Jul 31, 2021
@CronosZX
Copy link
Author

Ah I see why it wasn't working.
Attack 2 was set to focused so it was only targeting one of the stored targets, makes sense now that I think about it although I dont remember reading about it anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attacks resolved: invalid Not a real bug report/feature request
Projects
None yet
Development

No branches or pull requests

3 participants