music_native: MIDI voice error

[ohrrpgce-bugbot]

[bz#154]

When listening to MIDI files prior to importing them, it occasionally uses the
voice from the previous file rather than the one in the currently playing file.

From: jms <jms_blkfox>
Reported version: 20060216 Serendipity+
Operating system: Windows XP
Severity: minor

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

Can you test this with the latest nightlies?
http://hamsterrepublic.com/ohrrpgce/archive/ohrrpgce-binary-win-nightly.zip

I am pretty sure that Mike already fixed this one.

[ohrrpgce-bugbot]

Comment author: @pkmnfrk

Eh, depends what he means by voice. If he means that a note may be stuck, then
yes it's fixed. If he means that the channel voices (instruments) are not reset,
that's a combination of the fact that they aren't reset, and that midi files
should explicitly set them. Otherwise, they'll either get a piano or whatever
instrument was on the channel before.

[ohrrpgce-bugbot]

Comment author: jms <jms_blkfox>

The instrament was carrying over from one file to another. Can't get it to do
that with the nightly

[ohrrpgce-bugbot]

Comment author: @rversteegen

This is definitely still there, and 100% reproducable.

I was using a alleg-native build of the lastest revision for this.

Just select nearly any bam file, lets say the oveworld theme in wandering
hamster. Then goto import music and select a song with funny insturments, eg
chuffy dance.bam. Hit esc and you make mangled songs.

[ohrrpgce-bugbot]

Comment author: @pkmnfrk

However, *this* bug is closed. The original reporter confirmed that it was
fixed. What you are describing is the second scenario I mentioned:

=====
If he means that the channel voices (instruments) are not reset,
that's a combination of the fact that they aren't reset, and that midi files
should explicitly set them. Otherwise, they'll either get a piano or whatever
instrument was on the channel before.
=====

If you want to open a new bug, go ahead. But, this one is closed.

[ohrrpgce-bugbot]

Comment author: @rversteegen

I was about to open a new bug, then re-read and realised that this *is* the
right place for this. Just because the original poster didn't get it (prehaps
didn't compare a pair of songs on which this happens? *shrug*) doesn't mean I'm
seeing something different.

Spoke to Mike on IRC, and decided:
* bam2midi is not specifying instruments in midis? (if default pianos are used?)
* midi player not resetting instruments (Mike argued it shouldn't, but piano is
default, I argued that it should reset because people may use a piano bank)

[ohrrpgce-bugbot]

Comment author: @pkmnfrk

OK, please try it now. I just comitted a patch that causes it to reset
instruments as well (but only if it's not being reset because it's paused).

[ohrrpgce-bugbot]

Comment author: @rversteegen

I tried the fix and it still appears.

Despite what I said earlier about it being "100% reproducable" now when I try it
again it rarely happens using the method I described. But I do notice some cool
effects due to the bug as I scroll up and down the import menu and from song to
song. Fugue in E Minor with a drum beat,. :P

Another thing I notice is that every time a song has the wrong instruments, when
I switch to it there is a short extra pause (half a second) before it starts
playing.

[ohrrpgce-bugbot]

Comment author: @pkmnfrk

I've commited some more fixes for stuff, so try it now.

[ohrrpgce-bugbot]

Comment author: @rversteegen

I didn't test this immediately because I didn't have access to the computer on
which it's broken - it doesn't seem to occur on my other one(s?).

Anyway it still appears.

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

*** Bug bz⁠#204 has been marked as a duplicate of this bug. ***