Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by one bug in assigning script buffer and heap wastes memory #47

Closed
ohrrpgce-bugbot opened this issue Mar 4, 2005 · 2 comments
Closed
Labels
bug Yeah... that's broken scripts Script commands or interpreter. See also "hspeak" or "script import" labels

Comments

@ohrrpgce-bugbot
Copy link

[bz#47]

When a script is run, it is assigned script buffer and heap one int ahead of
where it should be.

Additionally, if either the buffer or heap is filled exactly, an overflow is
triggered, even though the script fis completely

From: @rversteegen
Reported version: unknown

@ohrrpgce-bugbot
Copy link
Author

Comment author: @rversteegen

Created attachment 9
Patch to fix off by one errors in Runscript

I wasted too much time testing this one :/

Attached file: scrbufleak.txt (text/plain, 1035 bytes)
Description: Patch to fix off by one errors in Runscript

@ohrrpgce-bugbot
Copy link
Author

Comment author: @bob-the-hamster

Ooh! Thanks for noticing that. Good catch.
I have applied the patch.
Matking fixed. We can verify after quaternion.

@ohrrpgce-bugbot ohrrpgce-bugbot added scripts Script commands or interpreter. See also "hspeak" or "script import" labels bug Yeah... that's broken labels Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Yeah... that's broken scripts Script commands or interpreter. See also "hspeak" or "script import" labels
Projects
None yet
Development

No branches or pull requests

1 participant