"reset palette" reverts to default palette, not the last one loaded

[ohrrpgce-bugbot]

[bz#562]

Only One In All reports:

"How do I make it so that I change a master palette (for brightness settings)
and make it stay that way permanently, at least for the duration of the play? I
used the load palette command, but any other script that tweaks the palette
automatically changes the master palette back to the original/main and tweaks it
from there, not the current set master palette. Is there a way around this?"

It sounds to me like the default palette is being re-loaded before all tweaks, but I'll have to check the code to make sure.

A test-case would probably help a lot.

From: @bob-the-hamster
Reported version: 20080121 Voxhumana
Blocker for: bz⁠#517

[ohrrpgce-bugbot]

Comment author: @rversteegen

This was confusion over resetpalette reverting to the default palette, not the last one loaded. Should this be changed?

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

This was confusion over resetpalette reverting to the default palette, not the
last one loaded. Should this be changed?

Yeah, I think so. reset palette should be changed to reset to the current default palette-- that is to say, the last palette selected by load palette.

[ohrrpgce-bugbot]

Comment author: @rversteegen

This was confusion over resetpalette reverting to the default palette, not the
last one loaded. Should this be changed?

Yeah, I think so. reset palette should be changed to reset to the current
default palette-- that is to say, the last palette selected by load palette.

I suggest adding a "Changes:" section to whatsnew.txt

I wonder whether the current palette number (minus tweaks) should persist over saved games (by changing the default palette in gen()). The heroes would be drawn with the default palette on the load menu, though.

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

I suggest adding a "Changes:" section to whatsnew.txt

How long has "load palette" been around? *checks* oh, it is already in ubersetzung...

What about a separate "change default palette" command? That gets the same job done, but avoids breaking any games. The current documentation for "reset palette" is clear enough, and could be amended to reference the new command.

I wonder whether the current palette number (minus tweaks) should persist over
saved games (by changing the default palette in gen()). The heroes would be
drawn with the default palette on the load menu, though.

Hmmm... Well, if we write some code to intelligently remap a 16 color palette from one 256 color palette to another (which we probably want anyway) then heroes in savegames with non-default palettes could still be displayed sanely.

[ohrrpgce-bugbot]

Comment author: onlyoneinall

A "change default palette" command would be great. :) This would definitely add more versatility to color/brightness effects in OHR games. Would this be difficult to add?

[ohrrpgce-bugbot]

Comment author: @rversteegen

Changing title to something less misleading