"Blocked by" vehicle setting does nothing

[ohrrpgce-bugbot]

[bz#764]

The "blocked by" setting should prevent a vehicle from passing into a tile, but it apparently does nothing.

I have only tested this with the "Pass through walls" bitset enabled. It might work with that bitset disabled, but it is obviously intended to work with that bitset enabled.

We should really have a "vehicles" component in Bugzilla.

From: @arperry
Reported version: 20110506 Zenzizenzic
Operating system: Windows Vista
Severity: major

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

I can't completely blame this one on the cat. I intentionally designed the "Pass through walls" bitset to ignore ALL passability. I don't want to change it, for fear of breaking edge-cases in existing games.

But this is a bug.

I propose renaming the "Pass through walls" bitset to something like "Always ignore all passaibility" or "Never blocked by walls or tiles". Something that really accurately describes the way it works now.

Then we add a new "Pass through walls" bitset that ignores regular walls, but does NOT ignore "blocked by"

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

It is likely that the same problem that caused bug bz⁠#770 would have also messed up vehicle's "blocked by" checking

[ohrrpgce-bugbot]

Comment author: @rversteegen

I must have just fixed this (the passmap probe in want_to_check_for_walls), however I can't seem manage to reproduce the bug in older builds anyway.

Is this a two part bug report?

[ohrrpgce-bugbot]

Comment author: msw188

What is the status on this one? Is it safe to call this one fixed, or should we leave it open as a feature request for a "pass through walls but not through blocking tiles"?

[ohrrpgce-bugbot]

Comment author: @rversteegen

I must have just fixed this (the passmap probe in want_to_check_for_walls),

(I had spotted some typo in the vehicle passability code that was disabling some check.) I'm confused by James saying the behaviour was intentional, and then contradicting himself in comment 2, followed by the discovery of the typo. I think we ought to do some testing.

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

I'm confused by James saying the behaviour was intentional, and
then contradicting himself in comment 2, followed by the discovery of the typo.
I think we ought to do some testing.

It is entirely possible that I am confused, yes :)

[ohrrpgce-bugbot]

Comment author: @rversteegen

      What    |Removed                     |Added

----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |TOOCONFUSING

[rversteegen]

Note: my comment above was a joke. Also, this bug report was a followup to an email Adam had sent to the mailing list titled "Unintuitive "override walls" setting". to which James responded

I can explain my rationale for how vehicle blocking work: I left my
computer on and fell asleep, and the cat implemented it by walking on
the keyboard.

This report complains that the vehicle "blocked by" setting is overridden by "Pass through walls". We agreed (and I still agree) that's not a bug, and the solution to the mess is something else, so I'm closing this. I filed #1144 for getting rid of the "blocked by" setting.