Header code cleanup / circular dependency problems

[ohrrpgce-bugbot]

[bz#778]

Because the interdependencies of the .bi header files have grown rather tangled, it is not possible to add types from slices.bi to udts.bi

If you add #INCLUDE "slices.bi" to udts.bi, you get a bunch of circular dependencies because slices.bi includes "common.bi" (and also udts.bi)

Maybe it would make sense to move all TYPE's and ENUM's from slices.bi to udts.bi?

From: @bob-the-hamster
Reported version: 20110506 Zenzizenzic

[ohrrpgce-bugbot]

Comment author: @rversteegen

Doesn't it make more sense to move things OUT of udts.bi, to where they actually belong? You know, accepted good practise? For example, I'd move all of the sprite, palette, and font stuff into allmodex.bi. All the script types need to be moved into a separate header anyway, since the new interpreter won't use them.

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

Yes, that would also be an acceptable resolution to this bug :)

Looking over the file, I think a fair number of those types would be best placed in loading.bi

[ohrrpgce-bugbot]

Comment author: @rversteegen

If you want to split off types for RPG format records then I suggest a more intuitively named header - a new one.

[rversteegen]

Maybe I'll keep this bug for header code cleanup, and just change the title. udts.bi is still a huge mess of types and I wish it were better.

udts.bi now declares TYPE SliceFwd as Slice, which it needs because it contains a huge mess of UDTs, at least one of which includes slices, while slices.bi includes udts.bi (at least) because Map slices have TileMap pointers.

The graphics UDTs got moved to allmodex.bi, but the script interpreter ones should still be moved out.