-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROP pipeline prototype #7
Conversation
thanks @arunsurya77 you can use git submodule https://git-scm.com/book/en/v2/Git-Tools-Submodules and add the Python and Cython code to |
Please let me know when this is ready for review |
I have the C library inside the iris_pipeline in my fork now. I am
currently working to get the c lib as a separate repo as a submodule. Doing
some tweaking for this. i will anyway give a review request.
…On Thu, 27 Jun 2019 at 00:52, Andrea Zonca ***@***.***> wrote:
Please let me know when this is ready for review
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKB37LSJQOSWMXOQ6GC24ELP4RWTHANCNFSM4HIYR3FA>
.
|
@arunsurya77 I made some updates to |
Hi Andrea, I will check the merge conflicts and try to resolve them and add
the tests.
…On Mon, 16 Mar 2020 at 10:53, Andrea Zonca ***@***.***> wrote:
@arunsurya77 <https://github.com/arunsurya77> I made some updates to
iris_pipeline so there are some conflicts now, also make sure there are
some unit tests that automatically run. I currently have some tests which
are Jupyter Notebooks, I like them because they are easy to run
interactively and to debug anything gone wrong, it also includes some
plotting, see for example:
https://github.com/oirlab/iris_pipeline/blob/master/iris_pipeline/tests/run_image2_subarray.ipynb
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKB37LRIINB37IJIMKY7CBLRHZRRPANCNFSM4HIYR3FA>
.
|
docs/drsrop_pipeline.rst
Outdated
Execute the pipeline from the command line | ||
------------------------------------------ | ||
|
||
We can use ``strun`` from a terminal to execute the pipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have tmtrun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arunsurya77 you should use tmtrun
which automatically monkeypatches strun
@arunsurya77 what is the stage of this? |
Yeah I agree, sorry about the delay. I hadn't had time to work on this. I will try to fix some of the outstanding issues this week and update the rst file of this. There are some problems I am facing with the monkey patching. But I will atleast try to do push all the updates so that you can have a look. |
@arunsurya77 do you confirm this code is currently working on your machine? |
High I'm just editing the last bits for the rst documentation. I'll make a
pull request tonight. It's just a few more changes but everything is
working, I managed to fix the erros.
…On Tue, 9 Jun 2020 at 19:24, Andrea Zonca ***@***.***> wrote:
@arunsurya77 <https://github.com/arunsurya77> do you confirm this code is
currently working on your machine?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKB37LVCOU2CDQFO3VRG56LRV3VGFANCNFSM4HIYR3FA>
.
|
I have added most of the ROP Pipeline Skelton in this pull request. I have verified it working in another ubuntu system also. Just to give you the installation process. I have documented it in the rop_pipeline.rst file also. requirements -- download 'sample_ramp_new.fits<' https://figshare.com/articles/sample_ramp_new_fits/12462491> to iris_pipeline/tests/data/ and iris_pipeline/readout/tests/ . The pytest is currently minimal which just runs the ROP pipleine on the data file. I am adding more tests and some frames from the simulator. |
let's switch to #27 so I can help edit this. |
ROP pipeline prototype implementation. Implements sampling and non-linearity correction. Currently, non-linearity correction coefficients need to be supplied. Sampling code requires drsrop_clib, currently a separate repo. Documentation in drsrop_pipeline.rst (not linked)