Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Patch" version bump should have been major #16

Closed
kjs3 opened this issue Sep 3, 2020 · 4 comments
Closed

"Patch" version bump should have been major #16

kjs3 opened this issue Sep 3, 2020 · 4 comments
Labels
dependencies Pull requests that update a dependency file Hacktoberfest

Comments

@kjs3
Copy link

kjs3 commented Sep 3, 2020

The patch version bump from 1.3.0 to 1.3.1 contained some major dependency updates and probably should have been a 2.0.0.

Specifically the Nest version here changes the INestApplication type.

This broke my app with the following:

src/documentation/documentation.service.ts:44:39 - error TS2345: Argument of type 'import("/app/node_modules/@nestjs/common/interfaces/nest-application.interface").INestApplication' is not assignable to parameter of type 'import("/app/node_modules/nestjs-redoc/node_modules/@nestjs/common/interfaces/nest-application.interface").INestApplication'.
  Property 'registerRequestByContextId' is missing in type 'import("/app/node_modules/@nestjs/common/interfaces/nest-application.interface").INestApplication' but required in type 'import("/app/node_modules/nestjs-redoc/node_modules/@nestjs/common/interfaces/nest-application.interface").INestApplication'.

Can we revert this and do it again as a major version change? For the moment I pinned to 1.3.0.

@ChrisWun
Copy link

ChrisWun commented Sep 7, 2020

We got the same problem. Thanks for the issue :)

@ojoanalogo
Copy link
Owner

Oh, I'm sorry I didn't noticed this was a major problem, will update ASAP

@ojoanalogo ojoanalogo added the dependencies Pull requests that update a dependency file label Sep 18, 2020
@ojoanalogo
Copy link
Owner

Updated package to 1.3.2 as temporal mesure, reverted back changes made to dependencies, please update
@kjs3 @ChrisWun

@kjs3
Copy link
Author

kjs3 commented Oct 10, 2020

1.3.2 seems fine.
I would bump master to 2.0.0 before and release that. I assume that's fine for people on a later Nest.js.

@kjs3 kjs3 closed this as completed Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants