Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base_url override settings ignored #2

Closed
klausru opened this issue Sep 30, 2016 · 2 comments
Closed

base_url override settings ignored #2

klausru opened this issue Sep 30, 2016 · 2 comments

Comments

@klausru
Copy link

klausru commented Sep 30, 2016

Dear Božana Bokan

it seems that the plugin ignores the base_url override settings declared in config.inc.php

I`m using the plugin on www.medienpaed.com and the URLs contain the install path, which should not be shown due to the base_url override settings.
Maybe the problem is the construction of the URLs via $requestedUrl and getCompleteUrl() . Are there any workarounds or alternative methods to contruct the URL?

Thanks

@bozana
Copy link

bozana commented Oct 11, 2016

Hi @klausru, thanks a lot for reporting this -- I will try to fix it...

@klausru
Copy link
Author

klausru commented Oct 11, 2016

Thanks for having a look at it.
As a quick and dirty workaround I replaced the $requestedUrl in ShariffBlockPlugin.inc.php by:
$currentUrl = "//{$_SERVER['HTTP_HOST']}{$_SERVER['REQUEST_URI']}";
and called that with data-url="{$currentUrl|escape}"> in the /templates/shariffBlock.tpl
Although it works, I do not know whether this might cause security problems.

@ronste ronste closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants