Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage thingy & get to 90%+ #100

Closed
4 tasks
taoeffect opened this issue Jun 16, 2016 · 2 comments
Closed
4 tasks

Add code coverage thingy & get to 90%+ #100

taoeffect opened this issue Jun 16, 2016 · 2 comments
Labels
Kind:Test Level:Starter Note:Tooling Note:Up-for-grabs Good candidates for newcomers, because we *think* nobody is working on currently. Priority:High

Comments

@taoeffect
Copy link
Member

taoeffect commented Jun 16, 2016

Problem

Without static type checking or a compiler, we need to test the heck out this thing!

Solution

Use flow and/or add code coverage generation to grunt test process.

  • Set minimum threshold and tie it to Travis
  • Display badge on README
  • See this handy little bot: https://github.com/ethereum/go-ethereum/pull/2455#issuecomment-209975901
  • Make sure it counts tests performed through Nightmare
@taoeffect taoeffect added Note:Up-for-grabs Good candidates for newcomers, because we *think* nobody is working on currently. Kind:Test Level:Starter Note:Tooling labels Jun 16, 2016
@taoeffect taoeffect mentioned this issue Jun 16, 2016
@sandrina-p
Copy link
Contributor

Same as #420, I don't see this to be a high priority for us to finish the Prototype.

We also have #632 saying the same thing and it has Low priority. My suggestion is:

  1. update this issue with the additional info at Add code coverage to Cypress #632
  2. close Add code coverage to Cypress #632 as duplicated.
  3. Replace the priority label to Low.

What do you think @taoeffect?

@taoeffect
Copy link
Member Author

I'm going to close this in favor of #632 and #528.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind:Test Level:Starter Note:Tooling Note:Up-for-grabs Good candidates for newcomers, because we *think* nobody is working on currently. Priority:High
Projects
None yet
Development

No branches or pull requests

2 participants