Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor missed issues with 747 #772

Closed
taoeffect opened this issue Nov 9, 2019 · 1 comment · Fixed by #775
Closed

Minor missed issues with 747 #772

taoeffect opened this issue Nov 9, 2019 · 1 comment · Fixed by #775

Comments

@taoeffect
Copy link
Member

taoeffect commented Nov 9, 2019

Problem

I missed a few minor issues with #747 in my review, describing them all here:

Issue 1

{tag_}{var}{_tag} pattern

Issue 2

When no explanation is provided for why a person is being added to the group, empty quotes are shown:

Screen Shot 2019-11-09 at 10 23 50 AM

Issue 3

When visiting the link shown above in a private window, with no user signed up, instead of the welcome page we are shown a broken link:

Screen Shot 2019-11-09 at 10 25 20 AM

Issue 4

Avatar error in console after group creation:

Screen Shot 2019-11-10 at 7 47 30 PM

Solution

  1. Move {strong_} and {_strong} out of the string-to-be-translated and into the {username} variable as surrounding HTML
  2. Hide the explanation completely when it's empty
  3. Make sure the welcome screen is shown to new users who haven't yet signed up for links generated through proposals, and add a test to catch this in the future
  4. Change or remove the default avatar URL
@taoeffect
Copy link
Member Author

Note: edited issue to add issue 4 related to the avatar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants