New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix refactoring needs #29

Closed

okanaydin opened this issue Apr 20, 2021 · 0 comments · Fixed by #33

Assignees

Labels

Projects

Milestone

Owner

okanaydin commented Apr 20, 2021 •

edited

move BASE_API_URL to Gradle file
set build type for Http Logging Interceptor if it is on prod variant don't send logs
remove FrameLayout from the activity_main.xml if you don't need to set anything else
use web-p format for the image if you can find this format
move 'click listener' to 'init' in view holder
change the naming 'photoDataSource' with 'photoRemoteDataSource'
set an app icon
remove Glide implementation

okanaydin added the improvement label

okanaydin added this to the 1.0 milestone

okanaydin self-assigned this

okanaydin added this to In progress in Board

okanaydin linked a pull request

that will close this issue

fix refactoring needs #33

Merged

okanaydin moved this from In progress to Done in Board

okanaydin closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment