Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some minor issues #37

Merged
merged 1 commit into from
May 2, 2021
Merged

fix some minor issues #37

merged 1 commit into from
May 2, 2021

Conversation

okanaydin
Copy link
Owner

  • move BaseFragment to the core package
  • @path(id) is should be non-null in Post Service
  • change variables with 'val' in the data classes, you don't need to re-assignee those
  • change the naming for 'PostDetailRepository' , 'PostDetailUseCase', 'CommentsDiffUtil' and check the other ones
  • create PostViewState
  • @Inject your adapters in Fragments
  • add @androidentrypoint for Splash Screen
  • ViewState classes should be taken non-null parameters
  • change the naming for functions because some of them are not consistent

@okanaydin okanaydin linked an issue May 2, 2021 that may be closed by this pull request
fix some minor bugs #36
Closed
@okanaydin okanaydin merged commit 2df36e2 into dev May 2, 2021
@okanaydin okanaydin added this to the 1.0 milestone May 2, 2021
@okanaydin okanaydin added this to Done in Board May 2, 2021
@okanaydin okanaydin added the bug Something isn't working label May 2, 2021
@okanaydin okanaydin self-assigned this May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okanaydin okanaydin

Labels
bug Something isn't working
Projects
Board
Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

fix some minor bugs
1 participant
@okanaydin