Over Eager Rebuilds

[slangley]

When clicking on each tab in sequence (in the example), the tab being clicked on is reloaded (expected), as well as all tabs previously clicked on (unexpected). This results in potentially expensive build() calls to be run every time you click on a tab.

[okaryo]

@slangley
Thanks for creating the Issue and the PR!

I'll make sure it works here as well and I'll review the code for the PR. Please forgive me if I have to make some minor modifications on my end, such as the style of the code. For example, I may remove debug print.

I have to go to work now, so please wait a bit for me to respond..

[slangley]

No worries. No rush. Do what you need to do! Let me know if you want me to update.

…

On May 30, 2022, at 8:36 PM, Ryotaro Oka ***@***.***> wrote:  @slangley Thanks for creating the Issue and the PR! I'll make sure it works here as well and I'll review the code for the PR. Please forgive me if I have to make some minor modifications on my end, such as the style of the code. For example, I may remove debug print. I have to go to work now, so please wait a bit for me to respond.. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[okaryo]

Sorry to keep you waiting.

I reproduced the same problem in my environment. And this is over eager rebuilds as you said.
My knowledge of key and rebuild was poor, so I studied a little.
I will now look at the pull request code you created.

[okaryo]

fixed by #2 and #3