Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gov rest #566

Merged
merged 2 commits into from
Jan 19, 2021
Merged

add gov rest #566

merged 2 commits into from
Jan 19, 2021

Conversation

xiangjianmeng
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@xiangjianmeng xiangjianmeng merged commit 56e30bd into dev Jan 19, 2021
@xiangjianmeng xiangjianmeng deleted the mxj/add-gov-rest branch January 19, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilovers ilovers ilovers approved these changes

@yangyangyaha yangyangyaha Awaiting requested review from yangyangyaha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiangjianmeng @ilovers