Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poolswap #324

Merged
merged 3 commits into from Sep 12, 2020
Merged

poolswap #324

merged 3 commits into from Sep 12, 2020

Conversation

ilovers
Copy link
Contributor

@ilovers ilovers commented Sep 12, 2020

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@ilovers ilovers changed the title Poolswap poolswap Sep 12, 2020
@zhongqiuwood zhongqiuwood merged commit d6ac928 into master Sep 12, 2020
@zhongqiuwood zhongqiuwood deleted the poolswap branch September 12, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongqiuwood zhongqiuwood zhongqiuwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilovers @zhongqiuwood