block when send -1 to commitCh, format code #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
zhongqiuwood
approved these changes
Oct 8, 2021
| ndb.tempPrePersistNodeCache = ndb.prePersistNodeCache | ||
| ndb.prePersistNodeCache = map[string]*Node{} | ||
| ndb.mtx.Unlock() | ||
| for _, node := range ndb.tempPrePersistNodeCache { | ||
| if node.persisted == true || node.prePersisted == false { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
S1002: should omit comparison to bool constant, can be simplified to node.persisted (gosimple)
summerpro
force-pushed
the
ray/async-commit-format-code
branch
from
05943d6
to
7f0d70a
Compare
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 68.90% 67.58% -1.33%
==========================================
Files 22 24 +2
Lines 1846 2181 +335
==========================================
+ Hits 1272 1474 +202
- Misses 443 555 +112
- Partials 131 152 +21
|
zhongqiuwood
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.